8000 Make TH more usable and consistent by apaszke · Pull Request #720 · torch/torch7 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make TH more usable and consistent #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2016
Merged

Make TH more usable and consistent #720

merged 2 commits into from
Jul 20, 2016

Conversation

apaszke
Copy link
Contributor
@apaszke apaszke commented Jul 20, 2016

No description provided.

@soumith soumith merged commit 58b9acd into torch:master Jul 20, 2016
@soumith
Copy link
Member
soumith commented Jul 20, 2016

LGTM! thanks!

@ghostcow
Copy link

what does this mean for everyday usage?

@fmassa
Copy link
Contributor
fmassa commented Jul 26, 2016

You can more easily use it in standalone C applications, because you don't need to convert the returned indices from 1-based to 0-based at every function call.
But if you only use the lua interface, it doesn't change anything.
BTW, @apaszke , do you plan do do the same for cutorch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apaszke @soumith @ghostcow @fmassa
0