fix trait bounds on make `AsService` & `IntoService` #796

Boog900 · 2024-09-27T19:16:28Z

The trait bounds on AsService & IntoService both require that M: Service, however this defeats the purpose of the types as if we already require that M: Service then all the ServiceExt methods would already be reachable on M.

This PR changes the bounds to M: MakeService.

Boog900 · 2025-06-09T16:08:33Z

Just to add a bit more detail on why this is needed, see this issue: #253 and this PR: #492, this code is supposed to make this possible:

use tower::{make::MakeService, ServiceExt};

async fn example<T: MakeService<(), ()>>(mut t: T) {
    let _ = t.as_service().ready().await;
}

But currently this will give a compile error as T does not impl Service.

Just looking at the Service impl on AsService will show the mistake:

tower/tower/src/make/make_service.rs

Lines 233 to 237 in ec81e57

    
           impl<M, S, Target, Request> Service<Target> for AsService<'_, M, Request> 
        
           where 
        
               M: Service<Target, Response = S>, 
        
               S: Service<Request>, 
        
           {

M is required to impl Service, but it doesn't, that's why we need AsService as M doesn't impl Service it impls MakeService. We could add the Service bounds to T in my example but then that defeats the purpose of as_service/into_service.

If you instead pull in this patch you will see the example builds.

ripytide

Yep, this makes sense. I tried coming up with what the trait bounds would look like if you make M: MakeService and ended up with exactly the same results.

ripytide · 2025-07-05T12:45:03Z

Actually, after a bit more thought, while I still stand by that this PR fixes a accidental mistake in the blanket trait for implementing Service for all MakeServices. I don't actually see the point in the MakeService trait to begin with, in the docs it says its a trait alias, and some of the associated types/methods are named slightly differently, some are named the same as Service (like Future). Overall, I don't see it reducing the complexity of trait bounds for functions that take services returning other services and would probably choose to go without it in my own code.

And if you did want a trait alias making Service a super-trait of MakeService would make things a lot simpler.

Oh, I see MakeService is for where you don't want to explicitly implement Service to prevent it getting confused with regular Services. Hence the into_ and as_ methods that require explicit conversion. I'm still not sure it's worth the extra confusion of another trait though.

fix bounds on make AsService & IntoService

6c7faf0

ripytide approved these changes Jul 2, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix trait bounds on make `AsService` & `IntoService` #796

fix trait bounds on make `AsService` & `IntoService` #796

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix trait bounds on make AsService & IntoService #796

Are you sure you want to change the base?

fix trait bounds on make AsService & IntoService #796

Conversation

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix trait bounds on make `AsService` & `IntoService` #796

fix trait bounds on make `AsService` & `IntoService` #796