fix: use minimal tokio features in make and reconnect features
#828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Jun 13, 2025
|
You only partially implemented my suggestions. Here is what I meant: --- a/tower/Cargo.toml
+++ b/tower/Cargo.toml
@@ -50,7 +50,7 @@ load = ["tokio/time", "tracing", "pin-project-lite"]
load-shed = ["pin-project-lite"]
make = ["pin-project-lite", "tokio"]
ready-cache = ["futures-core", "futures-util", "indexmap", "tokio/sync", "tracing", "pin-project-lite"]
-reconnect = ["make", "tokio", "tracing"]
+reconnect = ["make", "tracing"]
retry = ["tokio/time", "util"]
spawn-ready = ["futures-util", "tokio/sync", "tokio/rt", "util", "tracing"]
steer = []
@@ -66,7 +66,7 @@ futures-util = { workspace = true, features = ["alloc"], optional = true }
hdrhistogram = { workspace = true, optional = true }
indexmap = { workspace = true, optional = true }
slab = { workspace = true, optional = true }
-tokio = { workspace = true, features = ["sync"], optional = true }
+tokio = { workspace = true, optional = true }
tokio-stream = { workspace = true, optional = true }
tokio-util = { workspace = true, optional = true }
tracing = { workspace = true, features = ["std"], optional = true } |
…m globally enabled feature of tokio
|
Done but I'm not sure if it is ok to remove |
|
Thanks! I just realized this isn't merged yet. Not sure what happened there. GitHub is telling me there's merge conflicts and I can't resolve them myself because I'm not allowed to push to your branch. Mind rebasing or merging our |
Sure! |
jplatte
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makeorreconnectboth features rely only on the basic tokio (tokio::io) and do not require theio-stdfeature, which instead leads to compilation errors on wasm32 target.This PR changes it to the mininal
tokio/syncto just enabletokio, improving compatibility with the wasm32 target.