Call on_eos for successful streams
#580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to fix two tests that assert that eos is not called so this might in fact be documentation issue although I suspect the test was just done in a way that it would pass without conscious decision that eos should be ignored unless it is needed for classifications. Also somewhat related is #483 which also fixes an issue related to eos in |
|
@jplatte would you mind taking a look? It would help me a lot if this made it into the next release (whenever that might be) |
jplatte
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #550.
on_eosis called only if classification declares that it cannot classify the response until eos.The documentation does not mention such limitation.
Solution
Pass the callback to the response body for it to be called even if it's not needed for response classification.