8000 Add support for Storage Classes and pre-provisioned PVs by ConaghFM · Pull Request #21 · totmicro/helms · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for Storage Classes and pre-provisioned PVs #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 13, 2025
Merged

Add support for Storage Classes and pre-provisioned PVs #21

merged 3 commits into from
Mar 13, 2025

Conversation

ConaghFM
Copy link
Contributor
@ConaghFM ConaghFM commented Mar 6, 2025

Add support for Storage Classes and pre-provisioned PVs

This PR adds support for two features for the Netbird Management pod PVC:

  • Specifying a storage class
  • Specifying an existing Persistent Volume

Storage Class

Users may wish to use a non-default Storage Class.

  • Added value .Values.management.persistentVolume.storageClass to populate the .spec.storageClassName field in the PVC manifest
  • The implementation preserves the underlying behaviour of the storageClassName field, i.e. empty string ("") has subtly different behaviour to no value (null).
  • The implementation also preserves the previous default behaviour of the chart - setting no value for the storageClassName field, thus the change is non-breaking

Pre-existing Persistent Volumes

Some users may wish to provision volumes separately from the chart (i.e. static provisioning), for example when migrating configuration data between environments or storage types.

  • Added value .Values.management.persistentVolume.existingPVName to populate the .spec.volumeName field in the PVC manifest

@marcportabellaclotet-mt
Copy link
Contributor
marcportabellaclotet-mt commented Mar 12, 2025 •
edited
Loading

Can you update the README and bump the chart version to 1.6.1 ?

@marcportabellaclotet-mt marcportabellaclotet-mt merged commit a2d2c43 into totmicro:main Mar 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcportabellaclotet-mt marcportabellaclotet-mt marcportabellaclotet-mt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ConaghFM @marcportabellaclotet-mt
0