8000 generate:entity-boilerplate no longer creates SQL files · Issue #172 · totten/civix · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

generate:entity-boilerplate no longer creates SQL files #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
artfulrobot opened this issue Feb 17, 2020 · 0 comments
Closed

generate:entity-boilerplate no longer creates SQL files #172

artfulrobot opened this issue Feb 17, 2020 · 0 comments

Comments

@artfulrobot
Copy link

In this line there's a call to a function that generates and returns SQL.

But that SQL is not saved anywhere.

It reports that it successfully wrote sql files, but in fact it did no such thing.
totten added a commit to artfulrobot/civix that referenced this issue Feb 18, 2020
@totten
Fix totten#172 - Compatibility with both 5.22 and 5.23
de16685 
The prior commit fixes things in >=5.23 but breaks compatibility with <=5.22.

This change extracts the duplicate formula for writing out files into a new
helper (`$createSql()`), and then it revises that helper to work with both the
older and newer signatures.
@totten totten closed this as completed in 2884559 Feb 18, 2020
totten added a commit that referenced this issue Feb 18, 2020
@totten
Merge pull request #173 from artfulrobot/artfulrobot-fix-172-missing-…
73040a5 
…sql-files

Fix #172: SQL files not written by generate:entity-boilerplate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@artfulrobot
0