fix linking issues #1352
Merged
fix linking issues #1352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the log:
```
PS \pythonocc-core\cmake-build> cmake .. `
>> -DOCCT_INCLUDE_DIR=\occt-7.8.0-vc143-64\inc `
>> -DOCCT_LIBRARY_DIR=\occt-7.8.0-vc143-64\win64\vc14\lib `
>> -DCMAKE_BUILD_TYPE=Release `
>> -DPYTHONOCC_INSTALL_DIRECTORY=\pythonocc-core\_install `
>> -DPython3_ROOT_DIR=\Python311
-- Building for: Visual Studio 17 2022
-- Selecting Windows SDK version 10.0.22621.0 to target Windows 10.0.22635.
-- The C compiler identification is MSVC 19.35.32217.1
-- The CXX compiler identification is MSVC 19.35.32217.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found OpenGL: opengl32
-- Found Python3: /Python311/python.exe (found version "3.11.9") found components: Interpreter Development Development.Module Development.Embed
-- Python3 interpreter:/Python311/python.exe
-- Python include directory: /Python311/include
-- Python library release: /Python311/libs/python311.lib
-- Found SWIG: /swigwin-4.2.1/swig.exe (found suitable version "4.2.1", minimum required is "4.2.1")
-- Disabled SWIG warnings
-- Disabled deprecation warnings for oce
-- pythonocc modules will be installed to: \pythonocc-core\_install
-- Found MSVC compiler: 1 1935
-- Configuring done (6.2s)
-- Generating done (2.2s)
-- Build files have been written to: /pythonocc-core/cmake-build
PS \pythonocc-core\cmake-build> msbuild .\DE.vcxproj
MSBuild version 17.5.1+f6fdcf537 for .NET Framework
Build started 12.07.2024 9:34:07.
Included response file: Microsoft Visual Studio\2022\Community\MSBuild\Current\Bin\MSBuild.rsp
Project "\pythonocc-core\cmake-build\DE.vcxproj" on node 1 (default targets).
Project "\pythonocc-core\cmake-build\DE.vcxproj" (1) is building "\pythonocc-core\c
make-build\ZERO_CHECK.vcxproj" (2) on node 1 (default targets).
PrepareForBuild:
Creating directory "x64\Debug\ZERO_CHECK\".
Creating directory "x64\Debug\ZERO_CHECK\ZERO_CHECK.tlog\".
InitializeBuildStatus:
Creating "x64\Debug\ZERO_CHECK\ZERO_CHECK.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
CustomBuild:
1>Checking Build System
FinalizeBuildStatus:
Deleting file "x64\Debug\ZERO_CHECK\ZERO_CHECK.tlog\unsuccessfulbuild".
Touching "x64\Debug\ZERO_CHECK\ZERO_CHECK.tlog\ZERO_CHECK.lastbuildstate".
Done Building Project "\pythonocc-core\cmake-build\ZERO_CHECK.vcxproj" (default targets).
PrepareForBuild:
Creating directory "DE.dir\Debug\".
Creating directory "\pythonocc-core\cmake-build\bin\Debug\".
Creating directory "DE.dir\Debug\DE.tlog\".
InitializeBuildStatus:
Creating "DE.dir\Debug\DE.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
CustomBuild:
Swig compile src/SWIG_files/wrapper/DE.i for python
Building Custom Rule /pythonocc-core/CMakeLists.txt
ClCompile:
Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.35.32215\bin\HostX64\x64\CL.exe /c /I"\pythonocc-core" /I"\pythonocc-core\OPENGL_INCLUDE_DIR" /I"\occt-7.8.0-
vc143-64\inc" /I"\pythonocc-core\src\SWIG_files\headers" /I"\pythonocc-core\src\T
esselator" /I"\pythonocc-core\src\Visualization" /I"\pythonocc-core\src\MeshDataS
ource" /I"\pythonocc-core\src\Addons" /Zi /nologo /W3 /WX- /diagnostics:column /Od /Ob0 /D _WINDLL
/D _MBCS /D WIN32 /D _WINDOWS /D SWIG_PYTHON_SILENT_MEMLEAK /D OCCT_NO_DEPRECATED /D WNT /D CSFDB /D HAVE_CONFIG_H /D
"CMAKE_INTDIR=\"Debug\"" /D DE_EXPORTS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR
/Fo"DE.dir\Debug\\" /Fd"DE.dir\Debug\vc143.pdb" /external:W0 /Gd /TP /wd4244 /wd4251 /wd4275 /wd4290 /errorReport:qu
eue /external:I "/Python311/include" /bigobj "\pythonocc-core\cmake-build\bin\DEPYTHON_
wrap.cxx"
DEPYTHON_wrap.cxx
Link:
Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.35.32215\bin\HostX64\x64\link.exe /ERRORREPO
RT:QUEUE /OUT:"\pythonocc-core\cmake-build\bin\Debug\_DE.pyd" /INCREMENTAL /ILK:"DE.dir\Debug\_DE.i
lk" /NOLOGO /LIBPATH:"/occt-7.8.0-vc143-64/win64/vc14/lib" /LIBPATH:"/occt-7.8.0-vc14
3-64/win64/vc14/lib/Debug" TKernel.lib TKMath.lib TKBRep.lib TKG2d.lib TKG3d.lib TKGeomBase.lib TKBO.lib TKBool.lib T
KFeat.lib TKFillet.lib TKGeomAlgo.lib TKHLR.lib TKMesh.lib TKOffset.lib TKPrim.lib TKShHealing.lib TKTopAlgo.lib TKXM
esh.lib TKDE.lib TKXSBase.lib TKDESTEP.lib TKDEIGES.lib TKDESTL.lib TKDEVRML.lib TKDECascade.lib TKDEOBJ.lib TKDEGLTF
.lib TKDEPLY.lib TKXCAF.lib TKXmlXCAF.lib TKBinXCAF.lib TKRWMesh.lib \Python311\libs\python311_d.lib kerne
l32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANI
FEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"/pythonocc-core
/cmake-build/bin/Debug/_DE.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"/python
occ-core/cmake-build/bin/Debug/DE.lib" /MACHINE:X64 /machine:x64 /DLL DE.dir\Debug\DEPYTHON_wrap.obj
Creating library /pythonocc-core/cmake-build/bin/Debug/DE.lib and object /pyth
onocc-core/cmake-build/bin/Debug/DE.exp
DEPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl TDF_Transaction::TDF_Transaction(class T
Collection_AsciiString const &)" (??0TDF_Transaction@@qeaa@AEBVTCollection_AsciiString@@@z) referenced in function "pub
lic: void __cdecl TDF_Transaction::`default constructor closure'(void)" (??_FTDF_Transaction@@QEAAXXZ) [\pythonocc-core\cmake-build\DE.vcxproj]
DEPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl TDF_ClosureMode::TDF_ClosureMode(bool)"
(??0TDF_ClosureMode@@qeaa@_N@Z) referenced in function "public: void __cdecl TDF_ClosureMode::`default constructor clos
ure'(void)" (??_FTDF_ClosureMode@@QEAAXXZ) [\pythonocc-core\cmake-build\DE.vcxproj]
DEPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl TDF_IDFilter::TDF_IDFilter(bool)" (??0TD
F_IDFilter@@qeaa@_N@Z) referenced in function "public: void __cdecl TDF_IDFilter::`default constructor closure'(void)"
(??_FTDF_IDFilter@@QEAAXXZ) [\pythonocc-core\cmake-build\DE.vcxproj]
DEPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl TDF_RelocationTable::TDF_RelocationTable
(bool)" (??0TDF_RelocationTable@@qeaa@_N@Z) referenced in function "public: void __cdecl TDF_RelocationTable::`default
constructor closure'(void)" (??_FTDF_RelocationTable@@QEAAXXZ) [\pythonocc-core\cmake-build\DE.vcxpro
j]
\pythonocc-core\cmake-build\bin\Debug\_DE.pyd : fatal error LNK1120: 4 unresolved externals [\pythonocc-core\cmake-build\DE.vcxproj]
Done Building Project "\pythonocc-core\cmake-build\DE.vcxproj" (default targets) -- FAILED.
Build FAILED.
"\pythonocc-core\cmake-build\DE.vcxproj" (default target) (1) ->
(Link target) ->
DEPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl TDF_Transaction::TDF_Transaction(class
TCollection_AsciiString const &)" (??0TDF_Transaction@@qeaa@AEBVTCollection_AsciiString@@@z) referenced in function "p
ublic: void __cdecl TDF_Transaction::`default constructor closure'(void)" (??_FTDF_Transaction@@QEAAXXZ) [L\pythonocc-core\cmake-build\DE.vcxproj]
DEPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl TDF_ClosureMode::TDF_ClosureMode(bool)
" (??0TDF_ClosureMode@@qeaa@_N@Z) referenced in function "public: void __cdecl TDF_ClosureMode::`default constructor cl
osure'(void)" (??_FTDF_ClosureMode@@QEAAXXZ) [\pythonocc-core\cmake-build\DE.vcxproj]
DEPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl TDF_IDFilter::TDF_IDFilter(bool)" (??0
TDF_IDFilter@@qeaa@_N@Z) referenced in function "public: void __cdecl TDF_IDFilter::`default constructor closure'(void)
" (??_FTDF_IDFilter@@QEAAXXZ) [\pythonocc-core\cmake-build\DE.vcxproj]
DEPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl TDF_RelocationTable::TDF_RelocationTab
le(bool)" (??0TDF_RelocationTable@@qeaa@_N@Z) referenced in function "public: void __cdecl TDF_RelocationTable::`defaul
t constructor closure'(void)" (??_FTDF_RelocationTable@@QEAAXXZ) [\pythonocc-core\cmake-build\DE.vcxp
roj]
\pythonocc-core\cmake-build\bin\Debug\_DE.pyd : fatal error LNK1120: 4 unresolved externals [\pythonocc-core\cmake-build\DE.vcxproj]
0 Warning(s)
5 Error(s)
Time Elapsed 00:00:06.53
```
msbuild /p:Configuration=Release .\BinXCAFDrivers.vcxproj
Creating library /pythonocc-core/cmake-build/bin/Release/BinXCAFDrivers.lib and object /pythonocc-core/cmake-build/bin/Release/BinXCAFDrivers.
exp
BinXCAFDriversPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl LDOM_XmlWriter::LDOM_XmlWriter(char const *)" (??0LDOM_XmlWriter@@qeaa@PEBD@Z) referenced in
function "public: void __cdecl LDOM_XmlWriter::`default constructor closure'(void)" (??_FLDOM_XmlWriter@@QEAAXXZ) [\pythonocc-core\cmake-build\BinXCAFDrivers.vcxpro
j]
\pythonocc-core\cmake-build\bin\Release\_BinXCAFDrivers.pyd : fatal error LNK1120: 1 unresolved externals [\pythonocc-core\cmake-build\BinXCAFDrive
rs.vcxproj]
Done Building Project "\pythonocc-core\cmake-build\BinXCAFDrivers.vcxproj" (default targets) -- FAILED.
Build FAILED.
"\pythonocc-core\cmake-build\BinXCAFDrivers.vcxproj" (default target) (1) ->
(Link target) ->
BinXCAFDriversPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl LDOM_XmlWriter::LDOM_XmlWriter(char const *)" (??0LDOM_XmlWriter@@qeaa@PEBD@Z) referenced
in function "public: void __cdecl LDOM_XmlWriter::`default constructor closure'(void)" (??_FLDOM_XmlWriter@@QEAAXXZ) [\pythonocc-core\cmake-build\BinXCAFDrivers.vcxp
roj]
\pythonocc-core\cmake-build\bin\Release\_BinXCAFDrivers.pyd : fatal error LNK1120: 1 unresolved externals [\pythonocc-core\cmake-build\BinXCAFDri
vers.vcxproj]
0 Warning(s)
2 Error(s)
STEPCAFControlPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl Graphic3d_CubeMap::Graphic3d_CubeMap(class opencascade::handle<class Image_PixMap> const &,b ool)" (??0Graphic3d_CubeMap@@qeaa@AEBV?$handle@VImage_PixMap@@@OpenCascade@@_N@Z) referenced in function "public: void __cdecl Graphic3d_CubeMap::`default constructor closure'(void)" (??_FGraphic3d_CubeMap@@QEAAXXZ) [\pythonocc-core\cmake-build\STEPCAFControl.vcxproj] STEPCAFControlPYTHON_wrap.obj : error LNK2019: unresolved external symbol "protected: __cdecl Aspect_Grid::Aspect_Grid(double,double,double,class Quantity_Color const &,class Quantity _Color const &)" (??0Aspect_Grid@@iEAA@NNNAEBVQuantity_Color@@0@Z) referenced in function "public: void __cdecl Aspect_Grid::`default constructor closure'(void)" (??_FAspect_Grid@@qea AXXZ) [\pythonocc-core\cmake-build\STEPCAFControl.vcxproj] \pythonocc-core\cmake-build\bin\Release\_STEPCAFControl.pyd : fatal error LNK1120: 2 unresolved externals [\pythonocc-core\cmake-build\STEPCAFContr ol.vcxproj] Done Building Project "\pythonocc-core\cmake-build\STEPCAFControl.vcxproj" (default targets) -- FAILED. Build FAILED. "\pythonocc-core\cmake-build\STEPCAFControl.vcxproj" (default target) (1) -> (Link target) -> STEPCAFControlPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl Graphic3d_CubeMap::Graphic3d_CubeMap(class opencascade::handle<class Image_PixMap> const & ,bool)" (??0Graphic3d_CubeMap@@qeaa@AEBV?$handle@VImage_PixMap@@@OpenCascade@@_N@Z) referenced in function "public: void __cdecl Graphic3d_CubeMap::`default constructor closure'(void) " (??_FGraphic3d_CubeMap@@QEAAXXZ) [\pythonocc-core\cmake-build\STEPCAFControl.vcxproj] STEPCAFControlPYTHON_wrap.obj : error LNK2019: unresolved external symbol "protected: __cdecl Aspect_Grid::Aspect_Grid(double,double,double,class Quantity_Color const &,class Quanti ty_Color const &)" (??0Aspect_Grid@@iEAA@NNNAEBVQuantity_Color@@0@Z) referenced in function "public: void __cdecl Aspect_Grid::`default constructor closure'(void)" (??_FAspect_Grid@@q EAAXXZ) [\pythonocc-core\cmake-build\STEPCAFControl.vcxproj] \pythonocc-core\cmake-build\bin\Release\_STEPCAFControl.pyd : fatal error LNK1120: 2 unresolved externals [\pythonocc-core\cmake-build\STEPCAFCon trol.vcxproj] 0 Warning(s) 3 Error(s)
Build FAILED. "\RWPly.vcxproj" (default target) (1) -> (Link target) -> RWPlyPYTHON_wrap.obj : error LNK2019: unresolved external symbol "protected: __cdecl PrsMgr_PresentableObject::PrsMgr_PresentableObject(enum PrsMgr_TypeOfPresentation3d)" (??0PrsMgr _PresentableObject@@iEAA@W4PrsMgr_TypeOfPresentation3d@@@z) referenced in function "public: void __cdecl PrsMgr_PresentableObject::`default constructor closure'(void)" (??_FPrsMgr_Pre sentableObject@@QEAAXXZ) [\RWPly.vcxproj] RWPlyPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl SelectMgr_Selection::SelectMgr_Selection(int)" (??0SelectMgr_Selection@@qeaa@H@Z) referenced in fun ction "public: void __cdecl SelectMgr_Selection::`default constructor closure'(void)" (??_FSelectMgr_Selection@@QEAAXXZ) [\RWPly.vcxproj] RWPlyPYTHON_wrap.obj : error LNK2019: unresolved external symbol "protected: __cdecl SelectMgr_SelectableObject::SelectMgr_SelectableObject(enum PrsMgr_TypeOfPresentation3d)" (??0Se lectMgr_SelectableObject@@iEAA@W4PrsMgr_TypeOfPresentation3d@@@z) referenced in function "public: void __cdecl SelectMgr_SelectableObject::`default constructor closure'(void)" (??_FSe lectMgr_SelectableObject@@QEAAXXZ) [\RWPly.vcxproj] RWPlyPYTHON_wrap.obj : error LNK2019: unresolved external symbol "protected: __cdecl AIS_InteractiveObject::AIS_InteractiveObject(enum PrsMgr_TypeOfPresentation3d)" (??0AIS_Interact iveObject@@iEAA@W4PrsMgr_TypeOfPresentation3d@@@z) referenced in function "public: void __cdecl AIS_InteractiveObject::`default constructor closure'(void)" (??_FAIS_InteractiveObject@ @QEAAXXZ) [\RWPly.vcxproj] RWPlyPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl SelectMgr_EntityOwner::SelectMgr_EntityOwner(int)" (??0SelectMgr_EntityOwner@@qeaa@H@Z) referenced in function "public: void __cdecl SelectMgr_EntityOwner::`default constructor closure'(void)" (??_FSelectMgr_EntityOwner@@QEAAXXZ) [\RWPly .vcxproj] RWPlyPYTHON_wrap.obj : error LNK2019: unresolved external symbol "protected: __cdecl PrsDim_Relation::PrsDim_Relation(enum PrsMgr_TypeOfPresentation3d)" (??0PrsDim_Relation@@iEAA@W4 PrsMgr_TypeOfPresentation3d@@@z) referenced in function "public: void __cdecl PrsDim_Relation::`default constructor closure'(void)" (??_FPrsDim_Relation@@QEAAXXZ) [ pythonocc-core\cmake-build\RWPly.vcxproj] RWPlyPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl AIS_ConnectedInteractive::AIS_ConnectedInteractive(enum PrsMgr_TypeOfPresentation3d)" (??0AIS_Conne ctedInteractive@@qeaa@W4PrsMgr_TypeOfPresentation3d@@@z) referenced in function "public: void __cdecl AIS_ConnectedInteractive::`default constructor closure'(void)" (??_FAIS_Connected Interactive@@QEAAXXZ) [\RWPly.vcxproj] RWPlyPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl AIS_ExclusionFilter::AIS_ExclusionFilter(bool)" (??0AIS_ExclusionFilter@@qeaa@_N@Z) referenced in f unction "public: void __cdecl AIS_ExclusionFilter::`default constructor closure'(void)" (??_FAIS_ExclusionFilter@@QEAAXXZ) [\RWPly.vcxproj ] RWPlyPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl V3d_AmbientLight::V3d_AmbientLight(class Quantity_Color const &)" (??0V3d_AmbientLight@@qeaa@AEBVQu antity_Color@@@z) referenced in function "public: void __cdecl V3d_AmbientLight::`default constructor closure'(void)" (??_FV3d_AmbientLight@@QEAAXXZ) [\pythonocc-cor e\cmake-build\RWPly.vcxproj] RWPlyPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl V3d_DirectionalLight::V3d_DirectionalLight(enum V3d_TypeOfOrientation,class Quantity_Color const &, bool)" (??0V3d_DirectionalLight@@qeaa@W4V3d_TypeOfOrientation@@AEBVQuantity_Color@@_N@Z) referenced in function "public: void __cdecl V3d_DirectionalLight::`default constructor closur e'(void)" (??_FV3d_DirectionalLight@@QEAAXXZ) [\RWPly.vcxproj] RWPlyPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl V3d_Plane::V3d_Plane(double,double,double,double)" (??0V3d_Plane@@qeaa@NNNN@Z) referenced in functi on "public: void __cdecl V3d_Plane::`default constructor closure'(void)" (??_FV3d_Plane@@QEAAXXZ) [\RWPly.vcxproj] \bin\Release\_RWPly.pyd : fatal error LNK1120: 11 unresolved externals [\RWPly.vcxproj] 0 Warning(s) 12 Error(s)
Done Building Project "\pythonocc-core\cmake-build\TPrsStd.vcx 8000 proj" (default targets) -- FAILED. Build FAILED. "\pythonocc-core\cmake-build\TPrsStd.vcxproj" (default target) (1) -> (Link target) -> TPrsStdPYTHON_wrap.obj : error LNK2019: unresolved external symbol "protected: __cdecl PrsMgr_PresentableObject::PrsMgr_PresentableObject(enum PrsMgr_TypeOfPresentation3d)" (??0PrsM gr_PresentableObject@@iEAA@W4PrsMgr_TypeOfPresentation3d@@@z) referenced in function "public: void __cdecl PrsMgr_PresentableObject::`default constructor closure'(void)" (??_FPrsMgr_P resentableObject@@QEAAXXZ) [\pythonocc-core\cmake-build\TPrsStd.vcxproj] TPrsStdPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl SelectMgr_Selection::SelectMgr_Selection(int)" (??0SelectMgr_Selection@@qeaa@H@Z) referenced in f unction "public: void __cdecl SelectMgr_Selection::`default constructor closure'(void)" (??_FSelectMgr_Selection@@QEAAXXZ) [\pythonocc-core\cmake-build\TPrsStd.vcxpr oj] TPrsStdPYTHON_wrap.obj : error LNK2019: unresolved external symbol "protected: __cdecl SelectMgr_SelectableObject::SelectMgr_SelectableObject(enum PrsMgr_TypeOfPresentation3d)" (??0 SelectMgr_SelectableObject@@iEAA@W4PrsMgr_TypeOfPresentation3d@@@z) referenced in function "public: void __cdecl SelectMgr_SelectableObject::`default constructor closure'(void)" (??_F SelectMgr_SelectableObject@@QEAAXXZ) [\pythonocc-core\cmake-build\TPrsStd.vcxproj] TPrsStdPYTHON_wrap.obj : error LNK2019: unresolved external symbol "protected: __cdecl AIS_InteractiveObject::AIS_InteractiveObject(enum PrsMgr_TypeOfPresentation3d)" (??0AIS_Intera ctiveObject@@iEAA@W4PrsMgr_TypeOfPresentation3d@@@z) referenced in function "public: void __cdecl AIS_InteractiveObject::`default constructor closure'(void)" (??_FAIS_InteractiveObjec t@@QEAAXXZ) [\pythonocc-core\cmake-build\TPrsStd.vcxproj] TPrsStdPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl Graphic3d_CubeMap::Graphic3d_CubeMap(class opencascade::handle<class Image_PixMap> const &,bool)" (??0Graphic3d_CubeMap@@qeaa@AEBV?$handle@VImage_PixMap@@@OpenCascade@@_N@Z) referenced in function "public: void __cdecl Graphic3d_CubeMap::`default constructor closure'(void)" (??_F Graphic3d_CubeMap@@QEAAXXZ) [\pythonocc-core\cmake-build\TPrsStd.vcxproj] TPrsStdPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl SelectMgr_EntityOwner::SelectMgr_EntityOwner(int)" (??0SelectMgr_EntityOwner@@qeaa@H@Z) reference d in function "public: void __cdecl SelectMgr_EntityOwner::`default constructor closure'(void)" (??_FSelectMgr_EntityOwner@@QEAAXXZ) [\pythonocc-core\cmake-build\TPr sStd.vcxproj] TPrsStdPYTHON_wrap.obj : error LNK2019: unresolved external symbol "protected: __cdecl PrsDim_Relation::PrsDim_Relation(enum PrsMgr_TypeOfPresentation3d)" (??0PrsDim_Relation@@iEAA@ W4PrsMgr_TypeOfPresentation3d@@@z) referenced in function "public: void __cdecl PrsDim_Relation::`default constructor closure'(void)" (??_FPrsDim_Relation@@QEAAXXZ) [pythonocc-core\cmake-build\TPrsStd.vcxproj] TPrsStdPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl AIS_ConnectedInteractive::AIS_ConnectedInteractive(enum PrsMgr_TypeOfPresentation3d)" (??0AIS_Con nectedInteractive@@qeaa@W4PrsMgr_TypeOfPresentation3d@@@z) referenced in function "public: void __cdecl AIS_ConnectedInteractive::`default constructor closure'(void)" (??_FAIS_Connect edInteractive@@QEAAXXZ) [\pythonocc-core\cmake-build\TPrsStd.vcxproj] TPrsStdPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl AIS_ExclusionFilter::AIS_ExclusionFilter(bool)" (??0AIS_ExclusionFilter@@qeaa@_N@Z) referenced in function "public: void __cdecl AIS_ExclusionFilter::`default constructor closure'(void)" (??_FAIS_ExclusionFilter@@QEAAXXZ) [\pythonocc-core\cmake-build\TPrsStd.vcx proj] TPrsStdPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl V3d_AmbientLight::V3d_AmbientLight(class Quantity_Color const &)" (??0V3d_AmbientLight@@qeaa@AEBV Quantity_Color@@@z) referenced in function "public: void __cdecl V3d_AmbientLight::`default constructor closure'(void)" (??_FV3d_AmbientLight@@QEAAXXZ) [\pythonocc-c ore\cmake-build\TPrsStd.vcxproj] TPrsStdPYTHON_wrap.obj : error LNK2019: unresolved external symbol "protected: __cdecl Aspect_Grid::Aspect_Grid(double,double,double,class Quantity_Color const &,class Quantity_Colo r const &)" (??0Aspect_Grid@@iEAA@NNNAEBVQuantity_Color@@0@Z) referenced in function "public: void __cdecl Aspect_Grid::`default constructor closure'(void)" (??_FAspect_Grid@@QEAAXXZ) [\pythonocc-core\cmake-build\TPrsStd.vcxproj] TPrsStdPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl V3d_DirectionalLight::V3d_DirectionalLight(enum V3d_TypeOfOrientation,class Quantity_Color const &,bool)" (??0V3d_DirectionalLight@@qeaa@W4V3d_TypeOfOrientation@@AEBVQuantity_Color@@_N@Z) referenced in function "public: void __cdecl V3d_DirectionalLight::`default constructor clos ure'(void)" (??_FV3d_DirectionalLight@@QEAAXXZ) [\pythonocc-core\cmake-build\TPrsStd.vcxproj] TPrsStdPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl V3d_Plane::V3d_Plane(double,double,double,double)" (??0V3d_Plane@@qeaa@NNNN@Z) referenced in func tion "public: void __cdecl V3d_Plane::`default constructor closure'(void)" (??_FV3d_Plane@@QEAAXXZ) [\pythonocc-core\cmake-build\TPrsStd.vcxproj] TPrsStdPYTHON_wrap.obj : error LNK2019: unresolved external symbol "public: __cdecl Font_FTFont::Font_FTFont(class opencascade::handle<class Font_FTLibrary> const &)" (??0Font_FTFon t@@qeaa@AEBV?$handle@VFont_FTLibrary@@@OpenCascade@@@z) referenced in function "public: void __cdecl Font_FTFont::`default constructor closure'(void)" (??_FFont_FTFont@@QEAAXXZ) [\pythonocc-core\cmake-build\TPrsStd.vcxproj] \pythonocc-core\cmake-build\bin\Release\_TPrsStd.pyd : fatal error LNK1120: 14 unresolved externals [\pythonocc-core\cmake-build\TPrsStd.vcxproj] 0 Warning(s) 15 Error(s) Update CMakeLists.txt
Done Building Project "\cmake-build\XCAFPrs.vcxproj" (default targets) -- FAILED. Build FAILED. "\cmake-build\XCAFPrs.vcxproj" (default target) (1) -> (Link target) -> XCAFPrsPYTHON_wrap.obj : error LNK2019: unresolved external symbol "protected: __cdecl TPrsStd_Driver::TPrsStd_Driver(void)" (??0TPrsStd_Driver@@iEAA@XZ) referenced in function _wra p_new_XCAFPrs_Driver [\cmake-build\XCAFPrs.vcxproj] \cmake-build\bin\Release\_XCAFPrs.pyd : fatal error LNK1120: 1 unresolved externals [\cmake-build\XCAFPrs.vcxproj]
Reviewer's Guide by SourceryThis pull request addresses linking issues encountered while building File-Level Changes
Tips
|
There was a problem hiding this comment.
Hey @Andrej730 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -188,9 +188,9 @@ set(OCCT_MODEL_LIBRARIES TKernel TKMath TKBRep TKG2d TKG3d TKGeomBase TKBO | |||
| TKBool TKFeat TKFillet TKGeomAlgo TKHLR TKMesh TKOffset | |||
| TKPrim TKShHealing TKTopAlgo TKXMesh) | |||
| set(OCCT_VISUALIZATION_LIBRARIES TKService TKV3d TKOpenGl TKMeshVS) | |||
| set(OCCT_DATAEXCHANGE_LIBRARIES TKDE TKXSBase TKDESTEP TKDEIGES TKDESTL TKDEVRML TKDECascade TKDEOBJ TKDEGLTF TKDEPLY TKXCAF TKXmlXCAF TKBinXCAF TKRWMesh) | |||
| set(OCCT_DATAEXCHANGE_LIBRARIES TKDE TKXSBase TKDESTEP TKDEIGES TKDESTL TKDEVRML TKDECascade TKDEOBJ TKDEGLTF TKDEPLY TKCDF TKLCAF TKXCAF TKVCAF TKXmlXCAF TKBinXCAF TKRWMesh TKService TKV3d) | |||
There was a problem hiding this comment.
question (documentation): Redundant inclusion of TKService and TKV3d in OCCT_DATAEXCHANGE_LIBRARIES and OCCT_OCAF_LIBRARIES.
It appears that TKService and TKV3d are included in both OCCT_DATAEXCHANGE_LIBRARIES and OCCT_OCAF_LIBRARIES. Please confirm if this redundancy is intentional and, if so, consider documenting the reason for future reference.
There was a problem hiding this comment.
It is intentional, see commits descriptions for the exact OCCT_VISUALIZATION_LIBRARIES symbols required to compile data exchange libraries.
There was a problem hiding this comment.
Thank you for the clarification, Andrej. Given that the inclusion of TKService and TKV3d in both OCCT_DATAEXCHANGE_LIBRARIES and OCCT_OCAF_LIBRARIES is intentional, it would be helpful to add a comment in the CMakeLists.txt file explaining this decision. This will provide context for future developers and maintainers. Would you be able to add a brief comment to that effect?
|
thank you @Andrej730 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was trying to build
pythonoccon Windows and met lots of linking issues, after this PR those issues are resolved.See each commit description for the exact symbols that were missing.
Command I was using to build
pythonocc.Summary by Sourcery
This pull request addresses and fixes the linking issues encountered when building
pythonoccon Windows by updating the CMakeLists.txt to include the required libraries in the OCCT_DATAEXCHANGE_LIBRARIES and OCCT_OCAF_LIBRARIES.