Review/prepare 7.8.1.1 #1401
Merged
Review/prepare 7.8.1.1 #1401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis PR updates the version number from 7.8.1 to 7.8.1.1 across various configuration and documentation files. The changes primarily involve updating version references in installation guides, build configurations, and package metadata. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @tpaviot - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's a typo in README.md - 'Decembre' should be 'December'
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -12,7 +12,7 @@ About | |||
| ----- | |||
| pythonocc provides 3D modeling and dataexchange features. It is intended to CAD/PDM/PLM/BIM development. It is based on the OpenCascade Technology modeling kernel. | |||
|
|
|||
| Latest release: [pythonocc-core 7.8.1 (May 2024)](https://github.com/tpaviot/pythonocc-core/releases/tag/7.8.1) | |||
| Latest release: [pythonocc-core 7.8.1.1 (Decembre 2024)](https://github.com/tpaviot/pythonocc-core/releases/tag/7.8.1.1) | |||
There was a problem hiding this comment.
suggestion (typo): Fix typo: 'Decembre' should be 'December'
Suggested change
| Latest release: [pythonocc-core 7.8.1.1 (Decembre 2024)](https://github.com/tpaviot/pythonocc-core/releases/tag/7.8.1.1) | |
| Latest release: [pythonocc-core 7.8.1.1 (December 2024)](https://github.com/tpaviot/pythonocc-core/releases/tag/7.8.1.1) |
Comment on lines
91
to
+93
| wget https://github.com/Open-Cascade-SAS/OCCT/archive/refs/tags/V7_8_1.tar.gz | ||
| tar -xvzf V7_8_1.tar.gz | ||
| cd OCCT-7.8.1 | ||
| cd OCCT-7.8.1.1 |
There was a problem hiding this comment.
issue (bug_risk): Version mismatch in OpenCascade download instructions
The wget command downloads version 7.8.1 but the instructions reference directory 7.8.1.1. This mismatch could cause build failures. Please update either the download URL or the directory name to ensure they match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update project version to 7.8.1.1 across documentation, build, and CI configurations.
CI:
Documentation: