8000 magic tqdm · Issue #443 · tqdm/tqdm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

magic tqdm #443

New issue

Have a question about this project? 8000 Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
KOLANICH opened this issue Sep 22, 2017 · 10 comments
Closed

magic tqdm #443

KOLANICH opened this issue Sep 22, 2017 · 10 comments
Assignees
@casperdcl
Labels
p3-enhancement 🔥 Much new such feature submodule-notebook 📓 Much web such IDE to-merge ↰ Imminent

Comments

@KOLANICH
Copy link
KOLANICH commented Sep 22, 2017 •
edited
Loading 
from isNotebook import isNotebook
from tqdm import *

"""Magic calling needed tqdm depending on environment"""

if isNotebook():
	mtqdm=tqdm_notebook
else:
	mtqdm=tqdm

where isNotebook is according to https://stackoverflow.com/questions/15411967/how-can-i-check-if-code-is-executed-in-the-ipython-notebook/39662359#39662359
@KOLANICH KOLANICH changed the title mtqdm magic tqdm Sep 22, 2017
@casperdcl casperdcl mentioned this issue Sep 25, 2017
Closed
@casperdcl casperdcl mentioned this issue Nov 13, 2017
Closed
@KOLANICH
Copy link
Author
KOLANICH commented Jan 8, 2018

@casperdcl

@casperdcl
Copy link
Member
casperdcl commented Jan 9, 2018 •
edited
Loading

This is nice but has the additional isNotebook dependency, and the SO link you mention doesn't seem conclusive. Might be better to add to the documentation rather than to the library

@KOLANICH
Copy link
Author
KOLANICH commented Jan 9, 2018

We have to reimplement IsNotebook. It's pretty tiny.

@casperdcl
Copy link
Member

yes but my concern is there doesn't seem to be a consensus on how precisely to write an isNotebook that actually works in all cases

@KOLANICH
Copy link
Author
KOLANICH commented Jan 9, 2018 •
edited
Loading

That one works very well, as intended.

@casperdcl casperdcl mentioned this issue Feb 3, 2018
Closed
@joshbode
Copy link
joshbode commented Feb 28, 2018 •
edited
Loading

I've been using the following in my library, where I only want the progress bars if I'm running in an IPython environment:

if 'IPython' in sys.modules:

    from IPython import get_ipython

    if 'IPKernelApp' in get_ipython().config:
        from tqdm import tqdm_notebook as tqdm
    else:
        from tqdm import tqdm

else:

    def tqdm(x, **kwargs):
        """Fake progress function."""

        return x

Not sure how robust it is, though, but it correctly distinguishes between terminal ipython and Jupyter Notebook/Lab. It does not correctly identify jupyter console though, incorrectly using tqdm_notebook

@joshbode
Copy link
joshbode commented Mar 1, 2018 •
edited
Loading

Something like this could possibly work, which correctly returns False for ipython, jupyter console and jupyter qtconsole:

import re
import psutil

def is_notebook():
    return any(
        re.search(r'\bjupyter-(lab|notebook)\b', x)
        for x in psutil.Process().parent().cmdline()
    )

I'm not sure if it works for remote kernels, though

@casperdcl casperdcl mentioned this issue Mar 16, 2018
Closed
@chengs
Copy link
Contributor
chengs commented Apr 26, 2018

maybe checking ipywidget instead of jupyter?

@casperdcl
Copy link
Member

Basically, we can detect:

  1. ipython/python
  2. jupyter console/notebook

the problem being that console is not distinguishable from notebook by design:

I'd be in favour of:

from tqdm.magic import tqdm

which would:

  • if in plain terminal/ipython: return tqdm
  • if in jupyter, actually return tqdm_notebook but warn that jupyter console won't work properly

casperdcl added a commit that referenced this issue May 31, 2018
@casperdcl
tqdm.magic
1f82e3e 
closes #443
casperdcl added a commit that referenced this issue Jun 3, 2018
@casperdcl
tqdm.autonotebook
39d5edf 
closes #443
@casperdcl casperdcl added p3-enhancement 🔥 Much new such feature to-merge ↰ Imminent submodule-notebook 📓 Much web such IDE labels Jun 3, 2018
@casperdcl casperdcl self-assigned this Jun 3, 2018
@casperdcl casperdcl mentioned this issue Jun 3, 2018
Closed
4 tasks
@KOLANICH
Copy link
Author

🎉

@qingquansong qingquansong mentioned this issue Aug 14, 2018
Closed
@JohnPaton JohnPaton mentioned this issue Mar 27, 2019
Merged
@Claudio9701 Claudio9701 mentioned this issue Dec 21, 2020
Merged
@poynting poynting mentioned this issue May 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@casperdcl casperdcl

Labels
p3-enhancement 🔥 Much new such feature submodule-notebook 📓 Much web such IDE to-merge ↰ Imminent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@KOLANICH @chengs @joshbode @casperdcl
0