8000 meta: update linter config to cover more files by mifi · Pull Request #4706 · transloadit/uppy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

meta: update linter config to cover more files #4706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2023
Merged

meta: update linter config to cover more files #4706

merged 2 commits into from
Sep 28, 2023

Conversation

mifi
Copy link
Contributor
@mifi mifi commented Sep 27, 2023

@mifi mifi requested a review from aduh95 September 27, 2023 04:18
Copy link
Member
@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to ignore .github markdown files?

@mifi
Copy link
Contributor Author
mifi commented Sep 27, 2023

we want to not ignore them, hence the prefix exclamation mark (!)

@mifi
Copy link
Contributor Author
mifi commented Sep 27, 2023

or you mean why are we currently ignoring them (before this PR)? that I don't know. have to git blame

@mifi
Copy link
Contributor Author
mifi commented Sep 27, 2023

it was added here: #4105
I'm guessing now but maybe we want to ignore .github because we don't want to run any linters when any of the files change inside .github, because it would create unnecessary github actions jobs

@Murderlon
Copy link
Member

Sorry I misread. This makes sense 👍

@aduh95 aduh95 changed the title fix missing lint meta: update linter config to cover more files Sep 27, 2023
Co-authored-by: Antoine du Hamel <antoine@transloadit.com>
@mifi mifi merged commit 4282f3d into main Sep 28, 2023
@mifi mifi deleted the fix-markdown-lint branch September 28, 2023 04:41
@github-actions github-actions bot mentioned this pull request Sep 29, 2023
github-actions bot added a commit that referenced this pull request Sep 29, 2023
| Package                   | Version | Package                   | Version |
| ------------------------- | ------- | ------------------------- | ------- |
| @uppy/audio               |   1.1.3 | @uppy/store-default       |   3.0.4 |
| @uppy/aws-s3              |   3.3.1 | @uppy/store-redux         |   3.0.4 |
| @uppy/aws-s3-multipart    |   3.7.0 | @uppy/svelte              |   3.1.0 |
| @uppy/companion           |   4.9.1 | @uppy/thumbnail-generator |   3.0.5 |
| @uppy/companion-client    |   3.4.1 | @uppy/transloadit         |   3.3.1 |
| @uppy/compressor          |   1.0.4 | @uppy/tus                 |   3.3.1 |
| @uppy/core                |   3.5.1 | @uppy/utils               |   5.5.1 |
| @uppy/dashboard           |   3.5.4 | @uppy/webcam              |   3.3.3 |
| @uppy/image-editor        |   2.2.1 | @uppy/xhr-upload          |   3.4.1 |
| @uppy/remote-sources      |   1.0.4 | uppy                      |  3.17.0 |

- meta: add Prettier (Antoine du Hamel / #4707)
- @uppy/aws-s3-multipart: retry signature request (Merlijn Vos / #4691)
- meta: update linter config to cover more files (Mikael Finstad / #4706)
- @uppy/image-editor: ImageEditor.jsx - remove 1px black lines (Evgenia Karunus / #4678)
- meta: delete `.yarn/releases/yarn-3.4.1.cjs` (Antoine du Hamel)
- meta: fix linter errors (Antoine du Hamel / #4704)
- @uppy/utils: test: migrate to Vitest for Uppy core and Uppy plugins (Antoine du Hamel / #4700)
- meta: run corepack yarn (Mikael Finstad)
- @uppy/companion: upgrade TS target (Mikael Finstad / #4670)
- @uppy/companion: use deferred length for tus streams (Mikael Finstad / #4697)
- @uppy/companion-client: fix a refresh token race condition (Mikael Finstad / #4695)
- meta: add companion hotfix doc (Mikael Finstad / #4683)
- meta: run type checks also for companion and add files to docker (Mikael Finstad / #4688)
- @uppy/svelte: revert breaking change (Antoine du Hamel / #4694)
- meta: Update yarn.lock (Artur Paikin)
- @uppy/companion: fix instagram/facebook auth error regression (Mikael Finstad / #4692)
- @uppy/aws-s3-multipart: aws-s3-multipart - call `#setCompanionHeaders` in `setOptions` (jur-ng / #4687)
- @uppy/svelte: Upgrade Svelte to 4 (frederikhors / #4652)
- @uppy/companion: add test endpoint for dynamic oauth creds (Mikael Finstad / #4667)
- meta: fix VITE_COMPANION_ALLOWED_HOSTS (Mikael Finstad / #4690)
- @uppy/companion: fix edge case for pagination on root (Mikael Finstad / #4689)
- @uppy/companion: fix onedrive pagination (Mikael Finstad / #4686)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0