Support Angular 19 #5709
Merged
Support Angular 19 #5709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff output filesNo diffThe following build files have been modified and might affect the actual diff: |
96f31f1 to
09412a0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Murderlon
approved these changes
Apr 7, 2025
|
Thank you! |
mifi
added a commit
that referenced
this pull request
Apr 8, 2025
|
Looks like e2e tests failed from this PR so we reverted it. Could you re-create the PR and have a look at the e2e test failure @ArnaudFlaesch ? |
Merged
github-actions bot
added a commit
that referenced
this pull request
Apr 8, 2025
| Package | Version | Package | Version | | -------------------------- | ------- | -------------------------- | ------- | | @uppy/audio | 2.1.2 | @uppy/locales | 4.5.2 | | @uppy/box | 3.2.2 | @uppy/onedrive | 4.2.3 | | @uppy/companion | 5.6.0 | @uppy/react | 4.2.3 | | @uppy/core | 4.4.4 | @uppy/remote-sources | 2.3.2 | | @uppy/dashboard | 4.3.3 | @uppy/screen-capture | 4.2.2 | | @uppy/drag-drop | 4.1.2 | @uppy/status-bar | 4.1.3 | | @uppy/dropbox | 4.2.2 | @uppy/transloadit | 4.2.2 | | @uppy/facebook | 4.2.2 | @uppy/unsplash | 4.3.3 | | @uppy/file-input | 4.1.2 | @uppy/url | 4.2.3 | | @uppy/google-drive | 4.3.2 | @uppy/utils | 6.1.3 | | @uppy/google-drive-picker | 0.3.4 | @uppy/webcam | 4.1.2 | | @uppy/google-photos-picker | 0.3.4 | @uppy/webdav | 0.3.2 | | @uppy/image-editor | 3.3.2 | @uppy/zoom | 3.2.2 | | @uppy/instagram | 4.2.2 | uppy | 4.14.0 | - @uppy/core: dry retryAll() and upload() (Mikael Finstad / #5691) - @uppy/angular: Revert "Support Angular 19" (Mikael Finstad / #5710) - @uppy/angular: Support Angular 19 (Arnaud Flaesch / #5709) - @uppy/companion: implement dropbox business teams (Mikael Finstad / #5708) - @uppy/utils: add msg mimetype (Merlijn Vos / #5699) - @uppy/core: fix locale type for plugins (Merlijn Vos / #5700) - examples: build(deps-dev): bump vite from 5.4.14 to 5.4.15 (dependabot[bot] / #5703) - @uppy/locales: Update nb_NO.ts (Tore Sinding Bekkedal / #5678) - meta: build(deps): bump docker/login-action from 3.3.0 to 3.4.0 (dependabot[bot] / #5689) - examples: @uppy-example/aws-nodejs: fix fileType not present in S3 objects (Prakash / #5680) - @uppy/core: fix events when retrying with upload() (Prakash / #5696) - meta: Fix locales building (Mikael Finstad / #5693) - @uppy/google-photos: remove google photos 😢 (Mikael Finstad / #5690) - @uppy/locales: Update cs_CZ.ts (David Petrásek / #5658)
Sure, where can I see the logs for the e2e tests ? |
ArnaudFlaesch
added a commit
to ArnaudFlaesch/uppy
that referenced
this pull request
Apr 8, 2025
Co-authored-by: Murderlon <merlijn@soverin.net>
Thanks, I'm currently removing the NgModules because they're not needed anymore, I'll recreate the PR soon. |
ArnaudFlaesch
added a commit
to ArnaudFlaesch/uppy
that referenced
this pull request
Apr 8, 2025
Co-authored-by: Murderlon <merlijn@soverin.net>
|
Here : #5715 (still need to fix the packages install, I'm sorry I don't usually use Yarn) |
ArnaudFlaesch
added a commit
to ArnaudFlaesch/uppy
that referenced
this pull request
Apr 8, 2025
Co-authored-by: Murderlon <merlijn@soverin.net> test
mifi
pushed a commit
that referenced
this pull request
Apr 9, 2025
Merged
github-actions bot
added a commit
that referenced
this pull request
Apr 14, 2025
| Package | Version | Package | Version | | -------------------- | ------- | -------------------- | ------- | | @uppy/angular | 0.8.0 | uppy | 4.15.0 | | @uppy/provider-views | 4.4.3 | | | - @uppy/provider-views: Fix google photos picker (Mikael Finstad / #5717) - meta: build(deps): bump nanoid from 3.3.7 to 5.1.2 (dependabot[bot] / #5664) - examples: build(deps-dev): bump vite from 5.4.16 to 5.4.17 (dependabot[bot] / #5707) - @uppy/utils: Fix type check ci (Mikael Finstad / #5714) - @uppy/angular: Support Angular 19 (#5709) (Arnaud Flaesch / #5715) - meta: simplify e2e (Mikael Finstad / #5711) - meta: fix ready to commit (Mikael Finstad / #5713)
Murderlon
added a commit
that referenced
this pull request
Apr 15, 2025
* main: Fix google photos picker (#5717) build(deps): bump nanoid from 3.3.7 to 5.1.2 (#5664) build(deps-dev): bump vite from 5.4.16 to 5.4.17 (#5707) Fix type check ci (#5714) Support Angular 19 (#5709) (#5715) simplify e2e (#5711) fix ready to commit (#5713) Release: uppy@4.14.0 (#5712) dry retryAll() and upload() (#5691) Revert "Support Angular 19" (#5710) Support Angular 19 (#5709) implement dropbox business teams (#5708)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since using Uppy 18 with Angular 19 seems to work fine, I just updated the dependencies and the ranges, with the addition of the new inject() function for dependency injection.