8000 ePlease enter the commit message for your changes. Lines starting by frontinus · Pull Request #1 · trezor/async-hwi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ePlease enter the commit message for your changes. Lines starting #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: trezor-old
Choose a base branch
from
Open

ePlease enter the commit message for your changes. Lines starting #1

wants to merge 1 commit into from

Conversation

frontinus
Copy link

Are the calls to from_str and deserialized with slices passed by reference intentionally? Since thoses function simply take slices (and not &slices) we could call from_str(Res) or deserialize(Res) rather than from_str(&Res) on lines 22, 30 and 43

Furthermore the hwi.rs gives errors, do they need solving ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@frontinus
0