8000 Switch to bun by bovine3dom · Pull Request #5060 · tridactyl/tridactyl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Switch to bun #5060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Switch to bun #5060

wants to merge 1 commit into from

Conversation

bovine3dom
Copy link
Member

speedup is ~10x for no-ops and 1.5x for rebuilds, probably worth switching?

I think if we're switching to something that most people don't have we might as well go the whole hog and switch to devenv like was suggested in #5056

It would probably stop the annoying problems I get every year or so trying to update node on the buildbot too

🤔

https://stackoverflow.com/questions/74810175/migrate-yarn-lock-dependencies-to-bun-lockb-file/77302434#77302434

# convert yarn.lock to package-lock.json using synp
npx synp --source-file yarn.lock
 
# upgrade package-lock.json to version 3 using npm
npm i --lockfile-version 3 --frozen-lockfile
 
# convert package-lock.json to bun.lockb using bun
bun pm migrate

@bovine3dom
WIP: switch to bun
e83e660 
Tests need to be reinstated and yarn swapped for bun everywhere
@cooperpellaton
Copy link

I'll give this a look and help you out.

@cooperpellaton
Copy link

Can you rebase on master so I can open a PR from this branch to this PR? I got it all working 😄

@cooperpellaton
Copy link

I'll work on moving directly to bun from esbuild tomorrow.

https://bun.sh/docs/bundler/vs-esbuild

@bovine3dom
Copy link
Member Author

FWIW I'm reasonably happy with esbuild, it's already quick enough. The speedup to rebuild I'm talking about is just from running esbuild with bun rather than yarn.

My hope with switching to bun is that it will speed up switching branches where yarn install needs to be called with the git hook

But I need to balance that against making it annoying to cross the bun/yarn boundary in history when doing e.g. git bisect to hunt down a bug

@cooperpellaton
Copy link

I understand, though I do think that leaning into the idiomatic way of doing things from a tool is generally favorable and in this case removes a dependency. I've got that working in my branch if you want to check it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bovine3dom @cooperpellaton
0