10000 [AMD] Support splatted scale in MFMA by PMylon · Pull Request #7270 · triton-lang/triton · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[AMD] Support splatted scale in MFMA #7270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2025
Merged

[AMD] Support splatted scale in MFMA #7270

merged 3 commits into from
Jun 23, 2025

Conversation

PMylon
Copy link
Contributor
@PMylon PMylon commented Jun 23, 2025 •
edited by antiagainst
Loading

Fixes https://github.com/ROCm/triton-internal/issues/884

New contributor declaration

  • I am not making a trivial change, such as fixing a typo in a comment.

  • I have written a PR description following these
    rules.

  • I have run pre-commit run --from-ref origin/main --to-ref HEAD.

  • Select one of the following.

    • I have added tests.
      • /test for lit tests
      • /unittest for C++ tests
      • /python/test for end-to-end tests
    • This PR does not need a test because it enables previously skipped tests in python/test/unit/language/test_matmul.py.

  • Select one of the following.

    • I have not added any lit tests.
    • The lit tests I have added follow these best practices,
      including the "tests should be minimal" section. (Usually running Python code
      and using the instructions it generates is not minimal.)

antiagainst
antiagainst requested changes Jun 23, 2025
View reviewed changes
@PMylon PMylon force-pushed the support_splatted_scale_in_mfma branch from 5653f02 to 07fa641 Compare June 23, 2025 16:44
@PMylon PMylon requested a review from antiagainst June 23, 2025 16:58
@antiagainst antiagainst marked this pull request as ready for review June 23, 2025 17:04
@antiagainst antiagainst enabled auto-merge (squash) June 23, 2025 17:16
@antiagainst antiagainst merged commit 7f94609 into triton-lang:main Jun 23, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiagainst antiagainst antiagainst approved these changes

@zhanglx13 zhanglx13 Awaiting requested review from zhanglx13 zhanglx13 is a code owner

@ptillet ptillet Awaiting requested review from ptillet ptillet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PMylon @antiagainst
0