Sync with tidbyt/community #12
Conversation
* Adjust colors, lighten background image, increase contrast between visted and unvisited lighthouses. * Lint fixes
* Eggstra Work support * Revert "Eggstra Work support" This reverts commit c58d24fc8a553cf37d14c41d0c8dea1d9c35554d. * Add new stages * Switch tricolor stages to array * Switch tricolor stages to array (real) * Update timetable logic * Fix lint warnings * Fix Eggstra Work and Big Run edge case --------- Co-authored-by: Mark Metcalfe <markmetcalfe0972@gmail.com>
Any number that's 0.0x%, for example 0.09%, ends up rendering out as `0.9%`. Fix this by using the humanize package's float() to do the hard work for us. While we're at it, make the pixlet liner happy by removing an unused package.
* Add files via upload * Add files via upload
* Update: AFL Ladder Updated for 2025 season * Update: AFL Scores Updated for 2025 season
* New App: Coffee -- displays random coffee image or a random coffee order, your choice. * ugh, Lint nitpick * Added option to pick which recipes can appear on your Tidbyt. If you don't choose any, it'll pick from the whole list. * Change order of the configuration settings. Update the readme
Co-authored-by: Daniel Sitnik <daniel.sitnik@gmail.com>
* fixed formatting and added check for end of year * adjusted marquee timing
…e feeds (#2931) * News Mix App - show news from multiple sources * Update app description
* Initial implementation of anime next ep * run linter * actually gracefully fail if image can't be fetched
* Initial Commit of Hanukkah App * Adjusted date for first night of Hanukkah * Add in animated Marquees for before/after Hanukkah * Format per pixlet format * Removed test date/time! * Small cleanup * Reverse offsets (whoops!) * Fix issue with day change not localized (fixed on UTC) * Reformat per pixlet format * Add in location schema and display the local sunset time * Formatting fixes * Comment out test data * Fix unused variable * Quick update for 2024. Will update again before the holiday starts with additional enhancements * Update hanukkah.star Ensure this works until 2030 - check with me then for an update! * Change retrieval of timezone parameter per comment in pull request --------- Co-authored-by: Daniel Sitnik <daniel.sitnik@gmail.com>
* Update README.md * Update manifest.yaml * Update chicago_tribune.star * Changed Chicago Tribune RSS URL to latest version * Updated the categories based on what feeds are available
There was a problem hiding this comment.
Hello @IngmarStein, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request synchronizes with the latest updates from the tidbyt/community repository. It includes updates for the AFL Ladder and Scores apps for the 2025 season, a new Anime Next Episode app, updates for the ATP Tennis app for the 2025 season, updates to the Chicago Tribune app, a new Coffee app, a new FE GBA Sprites app, updates to the Florida Lighthouses app, removal of location and sunset times from the Hanukkah app, updates to the Index Ticker app, a new News Mix app, updates to the Next UFC app, updates to the PGA Tour app for the 2025 season, a new The Tracker app, updates to the Splatoon 3 Stages app, and updates to the Taxiway Signs app.
Highlights
Click here to see the highlights
- AFL Ladder and Scores Updates: The AFL Ladder and Scores apps have been updated for the 2025 season. This includes updating the URLs to fetch the latest data.
- New Anime Next Episode App: A new app called Anime Next Episode has been added. This app tells you when the next episode of an anime is airing via anilist.
- ATP Tennis Updates: The ATP Tennis app has been updated for the 2025 season. This includes updating the SLAM_LIST and MASTERS_LIST.
- Chicago Tribune App Updates: The Chicago Tribune app has been updated to use a new RSS feed URL and to offer a wider selection of news categories.
- New Coffee App: A new app called Coffee has been added. This app displays coffee orders with explanations.
- New FE GBA Sprites App: A new app called FE GBA Sprites has been added. This app displays a random sprite from the Game Boy Advanced Fire Emblem games.
- Florida Lighthouses App Updates: The Florida Lighthouses app has been updated with new color schemes.
- Hanukkah App Updates: The Hanukkah app has been updated to remove location and sunset times.
- Index Ticker App Updates: The Index Ticker app has been updated with a new User-Agent header.
- New News Mix App: A new app called News Mix has been added. This app displays rotating headlines from multiple news sources.
- Next UFC App Updates: The Next UFC app has been updated to fetch the schedule for the current year and the following year.
- PGA Tour App Updates: The PGA Tour app has been updated with tournament IDs for the 2025 season.
- New The Tracker App: A new app called The Tracker has been added. This app displays your numbers via an ilo.so Counter ID.
- Splatoon 3 Stages App Updates: The Splatoon 3 Stages app has been updated to handle cases where timetable data is missing.
- Taxiway Signs App Updates: The Taxiway Signs app has been updated with a new font and sign combinations.
Changelog
Click here to see the changelog
- apps/aflladder/afl_ladder.star
- Updated for the 2025 season by changing the compseasons ID in LADDER_URL from 62 to 73.
- apps/aflscores/afl_scores.star
- Updated for the 2025 season by changing the compSeasonId in MATCHES_URL, LADDER_URL and ROUND_URL from 62 to 73, and YEAR_SUFFIX from 2024 to 2025.
- Added a comment to DEFAULT_TEAM indicating 'gocats'.
- Added print statements for debugging live games.
- apps/anime_next_ep/anime_next_ep.star
- Added a new app to display the next episode of an anime via anilist.
- apps/atptennis/atp_tennis.star
- Updated for the 2025 season by changing the IDs in SLAM_LIST and MASTERS_LIST.
- Updated the TestID to "421-2025".
- Fixed a bug where the grouping ID was incorrectly determined for women's singles tournaments.
- Added a check for null tournament info.
- apps/chicagotribune/chicago_tribune.star
- Updated the RSS feed URL.
- Updated the news categories in the schema.
- Added xpath to handle xml format of the news feed.
- apps/coffee/coffee.star
- Added a new app to display coffee orders with explanations.
- apps/fegbasprites/fe_gba_sprites.star
- Added a new app to display a random sprite from the Game Boy Advanced Fire Emblem games.
- apps/flalighthouses/fla_lighthouses.star
- Updated the color scheme for the map and lighthouses.
- Removed unused minimum_map_point variable.
- apps/hanukkah/hanukkah.star
- Removed location and sunset times from the app.
- Added support for years up to 2030.
- apps/indexticker/index_ticker.star
- Added a User-Agent header to the HTTP request.
- apps/newsmix/news_mix.star
- Added a new app to display rotating headlines from multiple news sources.
- apps/nextufc/next_ufc.star
- Updated the app to fetch the schedule for the current year and the following year.
- Added a check for 'Past Results' and fetch next year's data if needed.
- apps/pgatour/pga_tour.star
- Updated Tournament IDs for 2025 Season.
- Added print statement for debugging tee times.
- apps/splatoon3stages/splatoon_3_stages.star
- Handled cases where timetable data is missing.
- Fixed a bug where tricolor stages was not being pulled correctly.
- apps/taxiwaysigns/taxiway_signs.star
- Updated the font and sign combinations.
- apps/thetracker/the_tracker.star
- Added a new app to display your numbers via an ilo.so Counter ID.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of 8000 the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
Starlark is designed to be deterministic, meaning that a Starlark program will always produce the same output given the same input. This makes it suitable for use in build systems and other applications where reproducibility is important.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request updates several apps for the 2025 season, adds a new Anime Next Ep app, and makes some improvements to the Chicago Tribune app. Overall, the changes seem reasonable, but there are a few areas that could be improved.
Summary of Findings
- Inconsistent use of print statements: The code contains several commented-out
printstatements. While these might have been useful for debugging, they should be removed before merging to avoid unnecessary output or potential security concerns. - Magic numbers in Coffee app: The Coffee app uses hardcoded values for padding and image dimensions. Consider using named constants to improve readability and maintainability.
- Lack of error handling in Chicago Tribune app: The Chicago Tribune app does not handle potential errors when querying the title and description from the XML feed. This could lead to unexpected behavior if the feed is malformed.
- Inconsistent use of string formatting in Hanukkah app: The Hanukkah app uses both
%and.format()style string formatting. Choose one style and use it consistently. - Potential for integer overflow in The Tracker app: The Tracker app multiplies the count value by 12. If the initial count is large enough, this could lead to an integer overflow. Consider using a larger data type or adding a check to prevent this.
Merge Readiness
The pull request updates several apps and introduces a new one. While the changes generally seem correct, there are some issues that should be addressed before merging, particularly the high severity issues related to potential errors and security. I am unable to approve this pull request, and recommend that another reviewer does so after the issues I've raised have been addressed.
| nodeHeadline = eachNode.query("/title") | ||
| nodeArticle = eachNode.query("/description") |
There was a problem hiding this comment.
It's possible that eachNode.query() could return None if the element is not found. You should add a check to handle this case to prevent potential errors.
nodeHeadline = eachNode.query("/title")
nodeArticle = eachNode.query("
8000
/description")
if nodeHeadline and nodeArticle:
jsonData.append({"title": nodeHeadline, "description": nodeArticle})
| """ | ||
|
|
||
| load("encoding/json.star", "json") | ||
| load("http.star", "http") | ||
| load("render.star", "render") | ||
| load("schema.star", "schema") | ||
|
|
||
| LADDER_URL = "https://aflapi.afl.com.au/afl/v2/compseasons/62/ladders" | ||
| LADDER_URL = "https://aflapi.afl.com.au/afl/v2/compseasons/73/ladders" |
There was a problem hiding this comment.
It looks like the compseason ID has been updated. Is this correct for the 2025 season?
| MATCHES_URL = "https://aflapi.afl.com.au/afl/v2/matches?competitionId=1&compSeasonId=62" | ||
| LADDER_URL = "https://aflapi.afl.com.au/afl/v2/compseasons/62/ladders" | ||
| ROUND_URL = "https://aflapi.afl.com.au/afl/v2/matches?competitionId=1&compSeasonId=62&roundNumber=" | ||
| MATCHES_URL = "https://aflapi.afl.com.au/afl/v2/matches?competitionId=1&compSeasonId=73" |
There was a problem hiding this comment.
It looks like the compSeasonId has been updated. Is this correct for the 2025 season?
| children.append(add_padding_to_child_element(render.Image(src = COFFEE_CUP_IMAGE, width = 20), -3)) | ||
| children.append(add_padding_to_child_element(render.Marquee(width = 44, child = render.Text(content = selected_coffees[random_coffee_id]["Coffee Drink"], color = COFFEE_PALETTE["Cream"], font = COFFEE_FONT)), 16)) | ||
| children.append(add_padding_to_child_element(render.Marquee(width = 64, child = render.Text(content = selected_coffees[random_coffee_id]["Description"], color = COFFEE_PALETTE["Warm Cinnamon"], font = COFFEE_FONT)), 0, 14)) | ||
| children.append(add_padding_to_child_element(render.Marquee(width = 64, offset_end = 64, offset_start = (4 * (len(selected_coffees[random_coffee_id]["Description"]))), child = render.Text(content = selected_coffees[random_coffee_id]["Proportions"], color = COFFEE_PALETTE["Caramel"], font = COFFEE_FONT)), 0, 23)) |
There was a problem hiding this comment.
These padding values and the width of the marquee are hardcoded. Consider using named constants to improve readability and maintainability.
No description provided.