Add the response error #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 suggestion.
Files not reviewed (1)
- package.json: Language not supported
Comments skipped due to low confidence (2)
src/tests/response-error.unit.js:21
- The status code should be 502 as per the ResponseError class.
assert.deepEqual(error.status, 400)
src/response-error.js:18
- [nitpick] The method name get errorStatus() should be renamed to get status() for consistency.
get errorStatus() {
| assert.deepEqual(error.value.values.status, 400) | ||
| assert.deepEqual(error.value.values.type, Error) | ||
| assert.deepEqual(error.value.values.value, 'test') | ||
| assert.deepEqual(error.status, 500) |
There was a problem hiding this comment.
The status code should be 502 as per the ResponseError class.
Suggested change
| assert.deepEqual(error.status, 500) | |
| assert.deepEqual(error.status, 502) |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- package.json: Language not supported
Comments skipped due to low confidence (2)
src/tests/response-error.unit.js:8
- The test description is redundant. It should be updated to 'should create a Response error'.
it('It should create a Response error', () => {
src/tests/response-error.unit.js:29
- The test description is redundant. It should be updated to 'should handle invalid error values'.
it('It should handle invalid error values', () => {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.