[bindings] Add crate tests for parsing metadata #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😎 Merged successfully - details. |
dfrankland
approved these changes
Jun 19, 2025
Comment on lines
+345
to
+346
| match parsed_meta.unwrap() { | ||
| VersionedBundle::V0_7_7(meta) => { |
There was a problem hiding this comment.
optional, but I find it nice: the assert_matches! macro can do this without needing to nest your statements
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #692 +/- ##
==========================================
+ Coverage 73.80% 74.12% +0.32%
==========================================
Files 68 68
Lines 14983 15023 +40
==========================================
+ Hits 11058 11136 +78
+ Misses 3925 3887 -38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 similar comment
cmillar-trunk
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were also missing conditional feature flags. These were failing to build locally when running from the crate directory. This passed CI because it runs all tests using the feature flag.