trunk-merge/pr-672/222d1974-6d83-4019-9153-4303148920ca #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to show loading indicators in the superconsole world. Also extracts out a bunch of the logic for rendering to a separate thread with channels to send messages so that we can handle messages from multiple threads (necessary because we have threads spun up to track progress on api calls).
… the parent thread exits before the render thread can finish printing out the final output.
Uses our outputters to format and display test command output more distinctly from the rest of the cli output.
…t-when-test-command-wrapped-with
Co-authored-by: Gabe <78751069+gnalh@users.noreply.github.com> Signed-off-by: cmillar-trunk <christian@trunk.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
==========================================
+ Coverage 73.80% 73.99% +0.18%
==========================================
Files 68 68
Lines 14983 15052 +69
==========================================
+ Hits 11058 11137 +79
+ Misses 3925 3915 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the main branch at SHA 4d35464c68be77d6150ca2d29a2afb8fe6ae3676.
See more details here.
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing the changes from pull request 672.
Dependencies
This pull request depends on the changes from pull request 692.