Stream stdout and stderr #699
Merged
+36
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel outputs its final summary to stdout, but progress logs to stderr. With stdout>stderr, we end up logging the summary above the progress. Since bazel shows up in so many places, we'll swap the order so it's more consistent with expectations.
|
😎 Merged successfully - details. |
|
/trunk cancel |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #699 +/- ##
==========================================
+ Coverage 73.21% 73.40% +0.19%
==========================================
Files 69 69
Lines 15590 15601 +11
==========================================
+ Hits 11414 11452 +38
+ Misses 4176 4149 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gnalh
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel outputs its final summary to stdout, but progress logs to stderr. With stdout>stderr, we end up logging the summary above the progress. Even worse, since we pipe it to a variable before printing, we end up sitting there doing nothing while waiting for the subcommand to print, and then dump the whole thing to the screen. This is fine if you're letting it run and not watching, but is a spooky experience if you are watching. Thus, we switch to passing both streams out directly, which also nicely interleaves them the way bazel expects.