8000 NAS-136301 / 25.10 / Prevent admin user lockout by mgrimesix · Pull Request #16630 · truenas/middleware · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NAS-136301 / 25.10 / Prevent admin user lockout #16630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025
Merged

NAS-136301 / 25.10 / Prevent admin user lockout #16630

merged 2 commits into from
Jun 17, 2025

Conversation

mgrimesix
Copy link
Contributor

Add validation to user update to prevent locking all admin user accounts.
The update to lock an admin user will be blocked if that user is the last remaining FULL_ADMIN user.

Passing CI test is here.

Added a CI test and fixed a flake8 complaint in account.py
@mgrimesix mgrimesix requested a review from a team June 17, 2025 01:36
@bugclerk bugclerk changed the title Prevent admin user lockout NAS-136301 / 25.10 / Prevent admin user lockout Jun 17, 2025
@bugclerk
Copy link
Contributor

@mgrimesix mgrimesix merged commit 8c12c39 into master Jun 17, 2025
2 checks passed
@mgrimesix mgrimesix deleted the NAS-136301 branch June 17, 2025 14:26
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

6BDF @truenas truenas locked as resolved and limited conversation to collaborators Jun 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0