8000 NAS-136374 / 25.10 / De-emphasize some fields in cloud credentials form by undsoft · Pull Request #12163 · truenas/webui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NAS-136374 / 25.10 / De-emphasize some fields in cloud credentials form #12163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025

Conversation

undsoft
Copy link
Collaborator
@undsoft undsoft commented Jun 19, 2025

Changes:

Cleans up Cloudsync provider form, hides some fields behind an editable where it makes sense.

Testing:

Check that fields work, compare with old implementation.

Downstream

Affects Reasoning
Documentation Visual changes to cloudsync provider form.

@undsoft undsoft requested a review from a team as a code owner June 19, 2025 14:34
@undsoft undsoft requested review from denysbutenko an 8000 d removed request for a team June 19, 2025 14:34
@bugclerk bugclerk changed the title NAS-136374: De-emphasize some fields in cloud credentials form NAS-136374 / 25.10 / De-emphasize some fields in cloud credentials form Jun 19, 2025
@bugclerk
Copy link
Contributor

Copy link
codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (b567ecb) to head (4c7b391).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12163   +/-   ##
=======================================
  Coverage   84.38%   84.38%           
=======================================
  Files        1740     1740           
  Lines       61716    61739   +23     
  Branches     6852     6852           
=======================================
+ Hits        52078    52101   +23     
  Misses       9638     9638           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member
@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looks good!

# Conflicts:
#	src/assets/i18n/ko.json
#	src/assets/i18n/ru.json
@undsoft undsoft enabled auto-merge (squash) June 20, 2025 07:49
@undsoft undsoft merged commit 25d57ea into master Jun 20, 2025
12 checks passed
@undsoft undsoft deleted the NAS-136374 branch June 20, 2025 08:15
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0