8000 NAS-135760 / 25.04.2 / Check auth mechanisms for token approval (by RehanY147) by bugclerk · Pull Request #12166 · truenas/webui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NAS-135760 / 25.04.2 / Check auth mechanisms for token approval (by RehanY147) #12166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2025
Merged

NAS-135760 / 25.04.2 / Check auth mechanisms for token approval (by RehanY147) #12166

merged 3 commits into from
Jun 23, 2025

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x 72bdbdb590cafe4f2d025a59c6245c9b3c9c4179
git cherry-pick -x f37945ed97d35f8cf42cd30d63aa47959a2fa3e3
git cherry-pick -x 7c11ec395d821cd8dfadc38f9625e8578583a620
git cherry-pick -x 188794654837c2af79fcc673afaa230c31e58ae7
git cherry-pick -x 8c6067513b7a97a3845f4f2dcdb185fbcad15b62
git cherry-pick -x bf7a99455a3ec016ce3535516f0ff607af30bb00

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 8f7d3a395efdff71801bc3244b21bb5212be745b

Changes:

Calls to auth.mechanism_choices to determine if token login is allowed

Testing:

Test login page for regressions. Also see ticket for specific testing instructions

Original PR: #12109

@bugclerk
Copy link
Contributor Author

Jira URL: https://ixsystems.atlassian.net/browse/NAS-135760

@RehanY147 @undsoft
NAS-135760: Check auth mechanisms for token approval
09c5cd7 
(cherry picked from commit 8f7d3a3)

# Conflicts:
#	src/app/modules/auth/auth.service.spec.ts
#	src/assets/i18n/ru.json
@undsoft undsoft marked this pull request as ready for review June 23, 2025 08:53
@undsoft undsoft requested a review from a team as a code owner June 23, 2025 08:53
@undsoft undsoft requested review from RehanY147 and removed request for a team June 23, 2025 08:53
undsoft
undsoft approved these changes Jun 23, 2025
View reviewed changes
Copy link
Collaborator
@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backported

@undsoft undsoft enabled auto-merge (squash) June 23, 2025 08:54
@codecov Codecov
Copy link
codecov bot commented Jun 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable/fangtooth@05a2c81). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/app/modules/auth/auth.service.ts 78.57% 3 Missing ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##             stable/fangtooth   #12166   +/-   ##
===================================================
  Coverage                    ?   83.15%           
===================================================
  Files                       ?     1668           
  Lines                       ?    59678           
  Branches                    ?     6337           
===================================================
  Hits                        ?    49623           
  Misses                      ?    10055           
  Partials                    ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@undsoft undsoft disabled auto-merge June 23, 2025 11:30
@undsoft undsoft merged commit bde6c62 into stable/fangtooth Jun 23, 2025
11 checks passed
@undsoft undsoft deleted the NAS-135760-25.04.2 branch June 23, 2025 11:30
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jun 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@undsoft undsoft undsoft approved these changes

@RehanY147 RehanY147 Awaiting requested review from RehanY147 RehanY147 is a code owner automatically assigned from truenas/ui-team

Assignees

@RehanY147 RehanY147

Labels
no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugclerk @undsoft @RehanY147
0