NAS-136168 / 25.10 / Update to Angular 20 #12121
Conversation
There was a problem hiding this comment.
- Fonts in buttons are different.
- Fonts in status pills (like in Shares) look different
- Colors in radio groups are incorrect.
- Toggle control looks different.
- Apps warning
Using 3rd party applications with TrueNAS...looks incorrect. Text too squished. - Header in job dialog and margins between other elements looks different.
- Checkboxes have different color, but it's okay to keep them gray. They do however need to have light checkmark on light themes.
- Boot Environments → Date Created now shows
Invalid Date. Same for dates in reporting. - Button group checkmark used to be white, not blue.
- There is a tiny scrollbar in confirmation dialog that says
You have unsaved changes.
Also I had to upgrade my node to make project build. We need to make sure our build process won't fail because of it. Please use Jenkins -> master -> custom with TRY_BRANCH_OVERRIDE to build your branch to make sure it builds.
| serial: null as null, | ||
| type: null as null, | ||
| rotationrate: null as null, | ||
| pool_info: null as null, |
There was a problem hiding this comment.
null as null means that only null is allowed as a value, which is not true. It's better to case as DashboardEnclosureSlot on the object.
| @@ -38,7 +38,7 @@ export const alertReducer = createReducer( | |||
| on(alertIndicatorPressed, (state) => ({ ...state, isPanelOpen: !state.isPanelOpen })), | |||
| on(alertPanelClosed, (state) => ({ ...state, isPanelOpen: false })), | |||
|
|
|||
| on(adminUiInitialized, (state) => ({ ...state, isLoading: true, error: null })), | |||
| on(adminUiInitialized, (state) => ({ ...state, isLoading: true, error: null as null })), | |||
| @@ -31,7 +31,7 @@ export const jobReducer = createReducer( | |||
| on(jobIndicatorPressed, (state) => ({ ...state, isPanelOpen: !state.isPanelOpen })), | |||
| on(jobPanelClosed, (state) => ({ ...state, isPanelOpen: false })), | |||
|
|
|||
| on(adminUiInitialized, (state) => ({ ...state, isLoading: true, error: null })), | |||
| on(adminUiInitialized, (state) => ({ ...state, isLoading: true, error: null as null })), | |||
There was a problem hiding this comment.
and here and in other places You should be able to use as string | null
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (74.46%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #12121 +/- ##
==========================================
+ Coverage 84.38% 84.49% +0.10%
==========================================
Files 1740 1740
Lines 61716 61734 +18
Branches 6852 6852
==========================================
+ Hits 52078 52161 +83
+ Misses 9638 9573 -65 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
package.json
Outdated
| @@ -44,24 +44,24 @@ | |||
| "url": "https://jira.ixsystems.com" | |||
| }, | |||
| "engines": { | |||
| "node": ">=18.19.1" | |||
| "node": ">=22.0.0" | |||
There was a problem hiding this comment.
We need to confirm that this is actually required by Angular and is supported by our build pipeline.
There was a problem hiding this comment.
angular.dev says at least 20.19 or higher.
Changes:
Testing:
Check pages 8000 for regressions introduced by adding new CSS variables in the material?
Downstream
TODO: