8000 Update mcp connection logic to be per server and in mcp schema by rahulkarajgikar · Pull Request #180 · truffle-ai/saiki · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update mcp connection logic to be per server and in mcp schema #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Update mcp connection logic to be per server and in mcp schema #180

merged 1 commit into from
Jun 24, 2025

Conversation

rahulkarajgikar
Copy link
Collaborator
@rahulkarajgikar rahulkarajgikar commented Jun 24, 2025 •
edited by coderabbitai bot
Loading

pending from last PR

Summary by CodeRabbit

  • New Features

    • Introduced a per-server connectionMode option ('strict' or 'lenient') for MCP server configurations, allowing explicit control over connection requirements during startup.
    • Added a global --strict CLI flag to enforce strict connection mode for all MCP servers.

  • Documentation

    • Updated guides and API documentation to explain the new connectionMode property, provide usage examples, and clarify best practices.
    • Added detailed instructions for using the --strict flag and configuring per-server connection modes.

  • Bug Fixes

    • Improved error handling to ensure startup only fails when required (strict) servers cannot connect.

  • Tests

    • Added and updated tests to verify correct handling and validation of the new connectionMode property.

  • Refactor

    • Simplified server initialization logic to use per-server connection modes and removed deprecated global connection mode settings.

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Jun 24, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce a per-server connectionMode property (with 'strict' or 'lenient' values) to all MCP server configurations, replacing the previous global mcpConnectionMode setting. Documentation, schemas, CLI, tests, and core logic are updated to support and validate this property. The CLI --strict flag now overrides all servers to strict mode individually.

Changes

Files/Paths Change Summary
docs/api/rest/mcp.md Expanded config parameter docs for "Add MCP Server" API; added connectionMode and example payload.
docs/docs/concepts/mcp.md Added connectionMode: strict to example YAML for filesystem tool registration.
docs/docs/guides/cli.md Added section explaining --strict CLI flag and its effect on MCP connections.
docs/docs/guides/configuring-saiki/mcpServers.md Documented per-server connectionMode, updated examples, and described CLI override.
src/app/index.ts Changed CLI --strict flag to set each server's connectionMode to 'strict' individually.
src/app/webui/components/ConnectServerModal.tsx Added connectionMode: 'lenient' to all server config submissions in the modal.
src/core/ai/agent/SaikiAgent.lifecycle.test.ts Updated tests for per-server connectionMode and moved systemPrompt in config.
src/core/client/manager.test.ts Added comprehensive tests for per-server connectionMode handling in MCPManager.
src/core/client/manager.ts Refactored to support per-server connectionMode; removed global mode; updated error handling.
src/core/config/schemas.test.ts Added tests for connectionMode default/validation in server config schemas.
src/core/config/schemas.ts Added optional connectionMode to server schemas; removed global mcpConnectionMode from agent config schema.
src/core/utils/service-initializer.ts Removed global mode logic; now only passes server configs to manager.

Sequence Diagram(s)

sequenceDiagram
    participant CLI/WebUI
    participant Config
    participant SaikiAgent
    participant MCPManager

    CLI/WebUI->>Config: Set per-server connectionMode (strict/lenient)
    CLI->>Config: (optional) Override all to strict with --strict
    Config->>SaikiAgent: Pass mcpServers with connectionMode
    SaikiAgent->>MCPManager: initializeFromConfig(mcpServers)
    loop For each server
        MCPManager->>Server: Attempt connect
        alt connectionMode == strict and fail
            MCPManager->>SaikiAgent: Throw error (startup fails)
        else connectionMode == lenient and fail
            MCPManager->>SaikiAgent: Ignore failure (startup continues)
        end
    end
    MCPManager-->>SaikiAgent: All strict servers connected
Loading

Poem

In a field of servers, strict and free,
Each one now chooses: how strict shall I be?
Lenient bunnies may hop and fail,
But strict ones must always blaze the trail.
With flags and configs, the garden's in tune—
Hooray for connection modes, under the moon!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-24T00_03_41_456Z-debug-0.log

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 05b131b and 9752547.

📒 Files selected for processing (12)
  • docs/api/rest/mcp.md (1 hunks)
  • docs/docs/concepts/mcp.md (1 hunks)
  • docs/docs/guides/cli.md (1 hunks)
  • docs/docs/guides/configuring-saiki/mcpServers.md (8 hunks)
  • src/app/index.ts (1 hunks)
  • src/app/webui/components/ConnectServerModal.tsx (3 hunks)
  • src/core/ai/agent/SaikiAgent.lifecycle.test.ts (2 hunks)
  • src/core/client/manager.test.ts (1 hunks)
  • src/core/client/manager.ts (3 hunks)
  • src/core/config/schemas.test.ts (3 hunks)
  • src/core/config/schemas.ts (3 hunks)
  • src/core/utils/service-initializer.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rahulkarajgikar rahulkarajgikar merged commit 96b5eb7 into truffle-ai:main Jun 24, 2025
2 of 4 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jun 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rahulkarajgikar
0