8000 feat: set composed stream taxonomies by MicBun · Pull Request #841 · trufnetwork/node · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: set composed stream taxonomies #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 11, 2025
Merged

feat: set composed stream taxonomies #841

merged 5 commits into from
Mar 11, 2025

Conversation

MicBun
Copy link
Member
@MicBun MicBun commented Mar 10, 2025 •
edited
Loading

Description

This pull request introduces several significant changes to the taxonomy handling and testing framework. The most important changes include updates to the SQL schema, implementation of the insert_taxonomy action, and enhancements to the testing setup for composed streams.

Updates to SQL Schema:

  • Modified the CREATE TABLE statement in 000-initial-data.sql to reorder columns, ensuring child_stream_id is correctly placed.

Implementation of insert_taxonomy Action:

  • Added a new implementation for the insert_taxonomy action in 004-composed-taxonomy.sql, which includes validation, versioning, and insertion logic for taxonomy records.

Enhancements to Testing Setup:

  • Added constants and variables for composed stream testing in query_test.go.
  • Introduced a new test setup helper WithComposedQueryTestSetup and a placeholder test testAGGR03_ComposedStreamWithWeights in query_test.go.
  • Reordered the taxonomy setup in setup/composed.go to ensure it is called after primitive streams are initialized. [1] [2]
  • Updated taxonomy weight handling to use decimals and adjusted the setTaxonomy function to call the new insert_taxonomy action in setup/composed.go. [1] [2]

Related Problem

resolves: #838

How Has This Been Tested?

Run test for WithComposedQueryTestSetup(testAGGR03_ComposedStreamWithWeights(t))

@MicBun MicBun added the type: feat New feature or request label Mar 10, 2025
@MicBun MicBun self-assigned this Mar 10, 2025
@MicBun MicBun linked an issue Mar 10, 2025 that may be closed by this pull request
Problem: can't set composed stream taxonomies #838
Closed
@MicBun MicBun force-pushed the feat/setTaxonomies branch from 54885f9 to b0670e5 Compare March 10, 2025 10:55
@MicBun MicBun changed the base branch from main to refactor/node-2.0 March 10, 2025 11:41
@MicBun MicBun requested a review from outerlook March 10, 2025 12:45
@MicBun MicBun marked this pull request as ready for review March 10, 2025 12:45
outerlook
outerlook reviewed Mar 10, 2025
View reviewed changes
outerlook
outerlook reviewed Mar 10, 2025
View reviewed changes
@MicBun MicBun requested review from outerlook and removed request for outerlook March 10, 2025 15:58
@MicBun MicBun force-pushed the feat/setTaxonomies branch from 7db1199 to 484c3ce Compare March 10, 2025 23:43
@MicBun MicBun mentioned this pull request Mar 10, 2025
Merged
@pr-time-tracker PR Time Tracker
Copy link
pr-time-tracker bot commented Mar 11, 2025 •
edited
Loading

@outerlook
⚠️⚠️⚠️
You must submit the time spent on this PR.
⚠️⚠️⚠️

@MicBun MicBun merged commit 785d9a2 into refactor/node-2.0 Mar 11, 2025
3 of 5 checks passed
@MicBun MicBun deleted the feat/setTaxonomies branch March 11, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outerlook outerlook outerlook approved these changes

Assignees

@MicBun MicBun

Labels
type: feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: can't set composed stream taxonomies
2 participants
@MicBun @outerlook
0