feat: get list streams #875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the new action "list_streams" along with its utility functions and tests to enable listing streams with support for parameters such as limit, offset, and order_by.
- Added ListStreamsInput struct and ListStreams function in the procedure utilities.
- Added a new test function testListStreams to validate the list_streams action.
- Adjusted test configuration to include the new test.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/streams/utils/procedure/execute.go | Implements the ListStreams function and supporting input struct for the new list_streams action |
| tests/streams/query/query_test.go | Introduces testListStreams to validate the list_streams action via a markdown table assertion |
Files not reviewed (1)
- internal/migrations/001-common-actions.sql: Language not supported
Comment on lines
+766
to
+772
| expected := fmt.Sprintf(` | ||
| | data_provider | stream_id | stream_type | created_at | | ||
| |---------------|-----------|-------------|------------| | ||
| | %s | %s | primitive | 1 | | ||
| | %s | %s | composed | 1 | | ||
| | %s | %s | primitive | 1 | | ||
| `, |
There was a problem hiding this comment.
The multi-line raw string literal used for the expected markdown table is indented, which may introduce unintended leading whitespace that could cause the table assertion to fail; consider removing or trimming the indentation.
Suggested change
| expected := fmt.Sprintf(` | |
| | data_provider | stream_id | stream_type | created_at | | |
| |---------------|-----------|-------------|------------| | |
| | %s | %s | primitive | 1 | | |
| | %s | %s | composed | 1 | | |
| | %s | %s | primitive | 1 | | |
| `, | |
| expected := strings.TrimSpace(fmt.Sprintf(` | |
| | data_provider | stream_id | stream_type | created_at | | |
| |---------------|-----------|-------------|------------| | |
| | %s | %s | primitive | 1 | | |
| | %s | %s | composed | 1 | | |
| | %s | %s | primitive | 1 | | |
| `, |
Copilot uses AI. Check for mistakes.
outerlook
approved these changes
Mar 31, 2025
|
@Copilot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new action
list_streamsand adds corresponding tests and utility functions to support it. The primary focus is on enabling the listing of streams with various parameters such as limit, offset, and order_by.New Action and Utility Functions:
internal/migrations/001-common-actions.sql: Added thelist_streamsaction to list streams with parameters for data provider, limit, offset, and order_by. This action includes validation for the limit parameter and default values for limit, offset, and order_by.tests/streams/utils/procedure/execute.go: Added theListStreamsInputstruct and theListStreamsfunction to execute thelist_streamsaction and process the result rows.Test Enhancements:
tests/streams/query/query_test.go: Added a new test functiontestListStreamsto validate thelist_streamsaction and included it in theTestQueryStreamtest suite. [1] [2]Related Problem
resolves: #871
How Has This Been Tested?