feat: null params return last record #919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
This commit introduces logic to return the latest record when both 'from' and 'to' parameters are omitted in the `get_record_primitive`, `get_index_primitive`, and `get_last_record_composed` actions across multiple SQL migration scripts. These changes improve historical consistency in data retrieval, ensuring that the most recent records are accessible when no specific time range is provided.
This commit introduces a new action, `internal_get_base_value`, to improve the retrieval of base values in composed queries. It also adds logic to handle maximum integer values in the `get_index_primitive` and `get_last_record_composed` actions, ensuring that closing deltas for open intervals are not emitted. These changes enhance the accuracy and reliability of historical data retrieval in SQL migrations.
This commit adds new test cases to the query test suite, ensuring that when 'from_time' and 'to_time' are omitted, the latest available record, index, and index change are returned. Additionally, it introduces tests for retrieving records and indices based on specific time parameters, improving the coverage and reliability of the query functionality.
Time Submission Status
|
MicBun
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adjusts the behavior of stream query actions (
get_record_primitive,get_index_primitive,get_record_composed,get_record_composed_index) to return only the latest record/index when both thefromandtotime parameters are omitted. This aligns the behavior with historical expectations. It also includes improvements to composed query logic and enhances test coverage and debugging for query functions.get_record_primitive,get_index_primitive,get_record_composed, andget_record_composed_indexto return the latest entry iffromandtoare NULL.get_record_composed_indexinto a new private helper actioninternal_get_base_value.@data_providerto$data_provider) inlist_streams.query_test.go):test_GetLatestRecord,test_GetLatestIndex,test_GetLatestIndexChange,test_GetRecordFromSpecificTime,test_GetRecordUntilSpecificTime,test_GetIndexFromSpecificTime,test_GetIndexUntilSpecificTime,test_GetIndexChangeFromSpecificTime,test_GetIndexChangeUntilSpecificTime) to cover scenarios wherefrom_timeand/orto_timeare omitted in query procedures.validateTableResultto output the actual result table in case of test failure, facilitating easier debugging.FormatResultRows.Related Problem
How Has This Been Tested?
tests/streams/query/query_test.goto cover the new logic for handling omitted time ranges in query procedures (get_record,get_index,get_index_change).