8000 chore: enhance filter_streams_by_existence action by outerlook · Pull Request #950 · trufnetwork/node · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: enhance filter_streams_by_existence action #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

chore: enhance filter_streams_by_existence action #950

merged 1 commit into from
May 28, 2025

Conversation

outerlook
Copy link
Contributor

Description

applies known improvement to efficiently filter streams

Related Problem

fix #949

How Has This Been Tested?

It's already applied. prior to this change, filtering 1000 streams took 40 seconds, now it's 1 second

@outerlook
feat: enhance filter_streams_by_existence action with recursive proce…
8000
09bf8e9 
…ssing

This commit updates the SQL action filter_streams_by_existence to utilize an efficient WITH RECURSIVE pattern for batch processing. The existing_only flag is now correctly referenced in the documentation, and the logic has been streamlined to improve performance and clarity. Additionally, new unit tests have been added to validate the functionality of the updated action, ensuring it correctly filters existing and non-existing streams based on the provided input.
@outerlook outerlook requested a review from MicBun May 28, 2025 18:37
@outerlook outerlook self-assigned this May 28, 2025
@pr-time-tracker PR Time Tracker
Copy link
pr-time-tracker bot commented May 28, 2025 •
edited
Loading

Time Submission Status

Member Status Time Action Last Update
outerlook ✅ Submitted 40min Update time May 28, 2025, 11:46 PM
MicBun ✅ Submitted 30min Update time May 29, 2025, 1:43 AM

@MicBun MicBun merged commit 6f2c5f1 into main May 28, 2025
3 of 5 checks passed
@MicBun MicBun deleted the chore/better-filter branch May 28, 2025 23:46
@MicBun MicBun changed the title feat: enhance filter_streams_by_existence action chore: enhance filter_streams_by_existence action May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MicBun MicBun MicBun approved these changes

Assignees

@outerlook outerlook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: checking stream existence is slow
2 participants
@outerlook @MicBun
0