chore: faster get_index
#981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the SQL migration to ensure that only active taxonomies are considered in the queries. It adds conditions to filter out taxonomies where `disabled_at` is not null, enhancing the accuracy of the data returned by the composed query. Additionally, the base value calculation logic is optimized to prioritize fetching the most relevant event data based on specified conditions.
This commit updates the SQL migration to ensure that the arrays of data providers and stream IDs have the same length before proceeding with ownership and permission checks. It refactors the logic to return results based on either ownership or permission, improving the accuracy of the checks for wallet access rights. These changes enhance the robustness of the authorization process in the system.
Time Submission Status
|
MicBun
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note that this still doesn't fix long
get_index_changequeries, which should be fixed when this issue is fixed:array_appendperformance is a bottleneck kwil-db#1522(will probably bring down to 9 seconds)
For now, when fetching under 365 data points (1 year if daily), this should not impact too much. But it grows in O(n²) with more data points.
Related Problem
How Has This Been Tested?
Summary table for CPI US:
get_recordget_indexget_index_changeget_index_change