8000 feat: expose list_role_members action & add coverage by outerlook · Pull Request #984 · trufnetwork/node · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: expose list_role_members action & add coverage #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

outerlook
Copy link
Contributor
@outerlook outerlook commented Jun 10, 2025

Description

  • Added list_role_members SQL action in migration 013 (already merged previously).
  • Introduced ListRoleMembersInput struct + ListRoleMembers helper in tests/streams/utils/procedure.
  • Extended role-management test suite with a sub-test that asserts returned member list after grant/revoke scenarios.

Related Problem

resolves: #983

How Has This Been Tested?

  • go test ./tsn-db/tests/... – all stream test suites pass, new test included in role_management_test.go.
  • Verified helper returns expected slice under pagination defaults (nil limit/offset).

This commit introduces a new SQL action, `list_role_members`, which retrieves members of a specified role with pagination support. It includes input validation for owner and role name, as well as sensible defaults for limit and offset parameters. Additionally, tests are added to ensure the correct functionality of the `list_role_members` action, verifying that it returns the expected wallet addresses based on role membership. This enhancement improves the role management capabilities within the system.
@outerlook outerlook requested a review from MicBun June 10, 2025 18:39
@outerlook outerlook self-assigned this Jun 10, 2025
Copy link
pr-time-tracker bot commented Jun 10, 2025

Time Submission Status

Member Status Time Action Last Update
@outerlook ❌ Missing - ⚠️ Submit time -
MicBun ✅ Submitted 15min Update time Jun 10, 2025, 6:48 PM

@MicBun MicBun merged commit b5817e8 into main Jun 10, 2025
3 of 5 checks passed
@MicBun MicBun deleted the feat/list-role-members branch June 10, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: missing list_role_members action
2 participants
0