8000 chore: enhance wallet write permission checks with batch processing by outerlook · Pull Request #991 · trufnetwork/node · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: enhance wallet write permission checks with batch processing #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2025
Merged

chore: enhance wallet write permission checks with batch processing #991

merged 2 commits into from
Jun 11, 2025

Conversation

outerlook
Copy link
Contributor

Description

Related Problem

How Has This Been Tested?

all tests pass

outerlook added 2 commits June 11, 2025 11:18
@outerlook
8000
chore: fix stream_exists_batch action and add direct testing
30ed027
@outerlook
feat: enhance wallet write permission checks with batch processing
61c7ace 
This commit updates the SQL action `is_wallet_allowed_to_write_batch` to utilize `WITH RECURSIVE` for efficient batch processing, combining ownership and permission checks in a single SQL context. It also improves error handling for invalid wallet addresses and ensures that arrays of data providers and stream IDs are validated for length consistency. Additionally, the Go test for write permissions is refactored to support multiple stream locators, enhancing the testing framework's robustness.
@outerlook outerlook self-assigned this Jun 11, 2025
@outerlook outerlook marked this pull request as ready for review June 11, 2025 15:33
@outerlook outerlook requested a review from MicBun June 11, 2025 15:33
@pr-time-tracker PR Time Tracker
Copy link
pr-time-tracker bot commented Jun 11, 2025 •
edited
Loading

Time Submission Status

Member Status Time Action Last Update
@outerlook ❌ Missing - ⚠️ Submit time -
MicBun ✅ Submitted 15min Update time Jun 12, 2025, 12:09 AM

@MicBun MicBun merged commit 62ff947 into main Jun 11, 2025
4 of 6 checks passed
@MicBun MicBun deleted the fix/return-existing branch June 11, 2025 15:44
@MicBun MicBun changed the title chore: fix stream_exists_batch action and add direct testing chore: enhance wallet write permission checks with batch processing Jun 12, 2025
@github-actions GitHub Actions
Copy link 
Hey there! 👋🏼

We require pull request titles to follow the max length convention and it looks like your proposed title needs to be adjusted.

Details:

Pull Request title "chore: enhance wallet write permission checks with batch processing" is greater than max length specified - 65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MicBun MicBun MicBun approved these changes

Assignees

@outerlook outerlook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: write permission non-tested
2 participants
@outerlook @MicBun
0