8000 feat: multi-level composed index by williamrusdyputra · Pull Request #1007 · trufnetwork/node · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: multi-level composed index #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 17, 2025
Merged

feat: multi-level composed index #1007

merged 4 commits into from
Jun 17, 2025

Conversation

williamrusdyputra
Copy link
Contributor
@williamrusdyputra williamrusdyputra commented Jun 17, 2025 •
edited
Loading

Related Problem

resolves: #1003

How Has This Been Tested?

  • migrated
  • multi_level_composed_test passed, previously failed
Screenshot 2025-06-17 at 12 08 37

Explanation: #1003 (comment)

@williamrusdyputra williamrusdyputra self-assigned this Jun 17, 2025
@williamrusdyputra

This comment was marked as resolved.

Sign in to view
@williamrusdyputra

This comment was marked as resolved.

Sign in to view
@williamrusdyputra williamrusdyputra marked this pull request as ready for review June 17, 2025 05:44
@pr-time-tracker PR Time Tracker
Copy link
pr-time-tracker bot commented Jun 17, 2025 •
edited
Loading

Time Submission Status

Member Status Time Action Last Update
williamrusdyputra ✅ Submitted 6h Updat 8000 e time Jun 17, 2025, 6:14 AM
MicBun ✅ Submitted 30min Update time Jun 17, 2025, 6:29 AM

MicBun
MicBun approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member
@MicBun MicBun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice jobs on fixing the calculation @williamrusdyputra

@MicBun MicBun merged commit 4cca4e3 into main Jun 17, 2025
6 checks passed
@MicBun MicBun deleted the feat/multi-level-composed-index branch June 17, 2025 06:14
@outerlook
Copy link
Contributor

very nice, and also remains performant

comparing get_record that didn't change and new get_index

Qty Streams: 400, Branching Factor: 8, Data Points: 365, Visibility: Public, Procedure: get_record, Samples: 1, Memory Usage: 513 MB
  Mean Duration: 906.373236ms
  Min Duration: 906.373236ms
  Max Duration: 906.373236ms

Qty Streams: 400, Branching Factor: 8, Data Poi
8612
nts: 365, Visibility: Public, Procedure: get_index, Samples: 1, Memory Usage: 589 MB
  Mean Duration: 973.096245ms
  Min Duration: 973.096245ms
  Max Duration: 973.096245ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MicBun MicBun MicBun approved these changes

@outerlook outerlook Awaiting requested review from outerlook

Assignees

@williamrusdyputra williamrusdyputra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Incorrect get_index result with nested composed streams
3 participants
@williamrusdyputra @outerlook @MicBun
0