evb_rk3399: revert CONFIG_SYS_MMC_ENV_DEV to 0 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
u-boot community does not handle PRs on GitHub, please read https://github.com/u-boot/u-boot/blob/master/README |
|
I figured, and I submitted the same patch to the mailing list on the same day, but did not get any feedback so far. |
fbertux
pushed a commit
to OSSystems/u-boot
that referenced
this pull request
Sep 29, 2020
Compiling U-Boot with ubsan/asan libraries and running it in sandbox
may lead to below backtrace:
=> avb init 0
=> avb verify
## Android Verified Boot 2.0 version 1.1.0
read_is_device_unlocked not supported yet
common/avb_verify.c:407:31: runtime error: division by zero
AddressSanitizer:DEADLYSIGNAL
Reviewed-by: Igor Opaniuk <igor.opaniuk@linaro.org>
=================================================================
==9388==ERROR: AddressSanitizer: FPE on unknown address 0x0000004b467f \
(pc 0x0000004b467f bp 0x000000000000 sp 0x7ffd899fe150 T0)
#0 0x4b467e in mmc_byte_io common/avb_verify.c:407
#1 0x4b4c47 in mmc_byte_io common/avb_verify.c:532
#2 0x4b4c47 in read_from_partition common/avb_verify.c:533
#3 0x69dc0d in load_and_verify_vbmeta lib/libavb/avb_slot_verify.c:560
#4 0x6a1ee6 in avb_slot_verify lib/libavb/avb_slot_verify.c:1139
#5 0x45dabd in do_avb_verify_part cmd/avb.c:245
#6 0x4af77c in cmd_call common/command.c:499
u-boot#7 0x4af77c in cmd_process common/command.c:538
u-boot#8 0x46bafc in run_pipe_real common/cli_hush.c:1677
u-boot#9 0x46bafc in run_list_real common/cli_hush.c:1875
u-boot#10 0x46c780 in run_list common/cli_hush.c:2024
u-boot#11 0x46c780 in parse_stream_outer common/cli_hush.c:3216
u-boot#12 0x46d34b in parse_file_outer common/cli_hush.c:3299
u-boot#13 0x4ad609 in cli_loop common/cli.c:217
u-boot#14 0x4625ae in main_loop common/main.c:65
u-boot#15 0x46f2d1 in run_main_loop common/board_r.c:648
u-boot#16 0x640253 in initcall_run_list lib/initcall.c:30
u-boot#17 0x46f9d0 in board_init_r common/board_r.c:879
u-boot#18 0x40539b in main arch/sandbox/cpu/start.c:321
u-boot#19 0x7fa94925f82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
u-boot#20 0x408908 in _start (/srv/R/u-boot-master/u-boot+0x408908)
AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: FPE common/avb_verify.c:407 in mmc_byte_io
==9388==ABORTING
Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
shenki
pushed a commit
to shenki/u-boot
that referenced
this pull request
Jul 28, 2022
Change-Id: I642bbbb0700c982119137d7cdae034635f9dc3d2
samueldr
pushed a commit
to samueldr/u-boot
that referenced
this pull request
Mar 27, 2023
Call trace:
PC: [< 00a7b36c >] printch+0x3c/0x68 /home4/cjh/uboot-nextdev/drivers/serial/ns16550.c:280
LR: [< 00a247e4 >] puts+0x1c/0x30 /home4/cjh/uboot-nextdev/common/console.c:592
Stack:
[< 00a7b36c >] printch+0x3c/0x68
[< 00ab337c >] printf+0x90/0xb4
[< 00a036e4 >] rk_board_fdt_fixup+0x30/0x1a8
[< 00a01f10 >] arch_fixup_fdt+0xc/0x94
[< 00a2aa28 >] image_setup_libfdt+0x14/0x114
[< 00a26d1c >] image_setup_linux+0x4c/0x6c
......
PC Surrounding Instructions:
a7b358: 528001a2 mov w2, #0xd // u-boot#13
a7b35c: b9000022 str w2, [x1]
a7b360: b4000192 cbz x18, a7b390 <printch+0x60>
a7b364: f9400642 ldr x2, [x18,u-boot#8]
a7b368: 373000e2 tbnz w2, u-boot#6, a7b384 <printch+0x54>
a7b36c: f940d242 ldr x2, [x18,u-boot#416]
a7b370: b4000102 cbz x2, a7b390 <printch+0x60>
a7b374: f940d241 ldr x1, [x18,u-boot#416]
a7b378: b9401422 ldr w2, [x1,u-boot#20]
a7b37c: 362fffe2 tbz w2, u-boot#5, a7b378 <printch+0x48>
a7b380: b9000020 str w0, [x1]
Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
Change-Id: I48391165094708dd86eeeabea09739a4c14fcf6f
charkear
pushed a commit
to HewlettPackard/gxp-uboot
that referenced
this pull request
Jun 28, 2023
Added License header and Fix coverity issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was changed to 1 in commit 0717dde, but a few months later,
commit 5f9411a swapped the order of eMMC and SD card by assigning
indexed aliases to
&sdhciand&sdmmc.