8000 Add hugetop command by eduardorittner · Pull Request #392 · uutils/procps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add hugetop command #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

eduardorittner
Copy link

The hugetop command displays system-wide hugepage informantion as well as per-process hugepage information.

It has the flags --human (for human-readable size output), --numa (to display info per numa core), --delay <N> (for display refresh) and --once (to only display once then exit). For now none of these flags are supported, and we currently only print once and then exit.

The info shown is also very minimal, but it's the same one which is displayed by the original hugetop. Since we get the info from /proc/meminfo and /sys/kernel/mm/hugepages/hugepages-<size>/... this is not portable at all and only works on linux.

@eduardorittner
Copy link
Author

I wanted to reuse some functionality from top, specifically the header formatting with time and things, and for that I made the header module public, if you have any suggestions they are welcome.

@cakebaker cakebaker mentioned this pull request Apr 29, 2025
Comment on lines 22 to 23
#[target.'cfg(target_os="windows")'.dependencies]
# windows = { workspace = true, features = ["Wdk_System_SystemInformation", "Win32_System_ProcessStatus", "Win32_System_SystemInformation"] }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to remove these lines

Copy link
Collaborator
@Krysztal112233 Krysztal112233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the late review of this PR. Since Debian's procps-ng does not currently include hugetop, I will continue the review later. I'm very sorry!

@Krysztal112233
Copy link
Collaborator

And since there were some conflicts due to the commits that were previously merged, could you please help fix them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0