-
Notifications
You must be signed in to change notification settings - Fork 30
Add hugetop command #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add hugetop command #392
Conversation
I wanted to reuse some functionality from |
src/uu/hugetop/Cargo.toml
Outdated
#[target.'cfg(target_os="windows")'.dependencies] | ||
# windows = { workspace = true, features = ["Wdk_System_SystemInformation", "Win32_System_ProcessStatus", "Win32_System_SystemInformation"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to remove these lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize for the late review of this PR. Since Debian's procps-ng does not currently include hugetop, I will continue the review later. I'm very sorry!
And since there were some conflicts due to the commits that were previously merged, could you please help fix them? |
The hugetop command displays system-wide hugepage informantion as well as per-process hugepage information.
It has the flags
--human
(for human-readable size output),--numa
(to display info per numa core),--delay <N>
(for display refresh) and--once
(to only display once then exit). For now none of these flags are supported, and we currently only print once and then exit.The info shown is also very minimal, but it's the same one which is displayed by the original hugetop. Since we get the info from
/proc/meminfo
and/sys/kernel/mm/hugepages/hugepages-<size>/...
this is not portable at all and only works on linux.