8000 Mosaic, fix repo rename error, fix buffering issues by ShashankBice · Pull Request #5 · uw-cryo/lidar_tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Mosaic, fix repo rename error, fix buffering issues #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 24, 2025
Merged

Conversation

ShashankBice
Copy link
Member

This PR introduces the ability to mosaic the output tiles into a final seamless composite.
While updating the code, I found issues in installation which was introduced due to not changing the repository name at some places while changing it at other places a few weeks ago. I also noticed that the buffering operation was not performed properly. I put fixes to both these issues. Finally, I updated the readme to reflect these changes.

Cheers,
Shashank

@scottyhq
Copy link
Member

This PR introduces the ability to mosaic the output tiles into a final seamless composite

Nice! Does this close #1 ?

else:
# process all at once, no tiling
dem_mosaic_opt.extend(['-o',outfn])
out = run_cmd('dem_mosaic',dem_mosaic_args+dem_mosaic_opt)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO for later: look into executing this directly from Python rather than run_cmd. Should probably add asp and pdal as dependencies

dependencies = [

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the issue is that asp does not have python API :( For everything else we will do the operations from within python!

@ShashankBice
Copy link
Member Author

This PR introduces the ability to mosaic the output tiles into a final seamless composite

Nice! Does this close #1 ?

Hi Scott, this addresses #1 partially. We do the mosaicking, but the reprojection step remains. I will contact you and David about that workflow later today/tomorrow since we need to check if the EPT files have heights relative to geoid or ellipsoid on our end. I will share a notebook; we can integrate it into the CLI workflow once we agree on the steps.

Co-authored-by: Scott Henderson <scottyhq@gmail.com>
@ShashankBice ShashankBice merged commit bbd89ef into main Feb 24, 2025
1 check failed
@ShashankBice ShashankBice deleted the mosaic branch May 19, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0