8000 Refactored django management commands to use self.stdout.write() by Eric-Butcher · Pull Request #713 · ubccr/coldfront · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactored django management commands to use self.stdout.write() #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Eric-Butcher
Copy link
Contributor

Refactored Django management commands to use self.stdout.write() instead of print(). This is in line with Django's docs on writing custom management commands.

@Eric-Butcher Eric-Butcher force-pushed the feature/refactor-management-commands-stdout branch from 06723d7 to baf3204 Compare June 30, 2025 20:52
@aebruno aebruno requested a review from ANekhai July 2, 2025 15:10
Copy link
Collaborator
@ANekhai ANekhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

Copy link
Member
@aebruno aebruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion on keeping the warning text. Otherwise looks good.

…ead of print().

Signed-off-by: Eric Butcher <107886303+Eric-Butcher@users.noreply.github.com>
@Eric-Butcher Eric-Butcher force-pushed the feature/refactor-management-commands-stdout branch from baf3204 to 549ffb1 Compare July 3, 2025 13:23
@Eric-Butcher Eric-Butcher requested a review from aebruno July 3, 2025 13:26
@aebruno aebruno merged commit 26e18a7 into ubccr:main Jul 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0