10000 Allow complex length check conditions to determine the slice being nonnil by yuxincs · Pull Request #348 · uber-go/nilaway · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow complex length check conditions to determine the slice being nonnil #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow complex length check conditions to determine the slice being nonnil #348

wants to merge 1 commit into from

Conversation

yuxincs
Copy link
Contributor
@yuxincs yuxincs commented Jul 2, 2025 •
edited
Loading

We can have different length checks in Go code i.e., 0 < len(a) - 1 instead of simply 0 < len(a) which would imply that a is nonnil. However, NilAway currently only reasons about simple cases like 0 < len(a). This PR adds the ability to reason about complex length check conditions by traversing the AST node and extracting the len(a) node.

Note that we maintain an unsound assumption that the length check yields nonnil a (unless explicitly checking for len(a) == 0) to reduce false positives.

Fixes #346

@codecov Codecov
Copy link
codecov bot commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.58%. Comparing base (d7085a7) to head (d8eee41).

Files with missing lines Patch % Lines
util/asthelper/asthelper.go 90.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #348   +/-   ##
=======================================
  Coverage   87.57%   87.58%           
=======================================
  Files          72       72           
  Lines       10819    10842   +23     
=======================================
+ Hits         9475     9496   +21     
- Misses       1155     1156    +1     
- Partials      189      190    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions
Copy link
github-actions bot commented Jul 2, 2025 •
edited
Loading

Golden Test

Note

✅ NilAway errors reported on standard libraries are identical.

2540 errors on base branch (main, fb40f5d)
2540 errors on test branch (7417bf5)

@yuxincs yuxincs force-pushed the yuxincs/handle-length-check branch from d8eee41 to 6fb682d Compare July 9, 2025 14:37
@yuxincs yuxincs force-pushed the yuxincs/handle-length-check branch from 6fb682d to 4544157 Compare July 11, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix len handling
1 participant
@yuxincs
0