8000 feat: introduce CellFrom/ToString by justinhwang · Pull Request #95 · uber/h3-go · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: introduce CellFrom/ToString #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

feat: introduce CellFrom/ToString #95

merged 1 commit into from
Jun 25, 2025

Conversation

justinhwang
Copy link
Collaborator
@justinhwang justinhwang commented Jun 24, 2025 •
edited
Loading

The preexisting IndexFromString and IndexToString utils aren't
strongly typed with Cells which requires casting between uint64 <>
Cell to use them.

Introduce CellFromString and CellToString functions for a quality
of life improvement.

@justinhwang justinhwang requested a review from jogly June 24, 2025 14:56
@coveralls
Copy link
coveralls commented Jun 24, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15859460037

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 15809115483: 0.0%
Covered Lines: 708
Relevant Lines: 708
💛 - Coveralls

jogly
jogly reviewed Jun 24, 2025
View reviewed changes
Copy link
Collaborator
@jogly jogly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little historical context,IndexFromString is named the way it is because it distinguished the uint64 representation from address, a string, or cell, a functional type. Instead of the breaking change, perhaps a good QoL improvement is to add CellFromString instead? Then, perhaps IndexFromString could be deprecated if it is not providing value.

@justinhwang
Copy link
Collaborator Author

A little historical context,IndexFromString is named the way it is because it distinguished the uint64 representation from address, a string, or cell, a functional type. Instead of the breaking change, perhaps a good QoL improvement is to add CellFromString instead? Then, perhaps IndexFromString could be deprecated if it is not providing value.

Yeah ack, makes sense - will update

@justinhwang justinhwang force-pushed the justinhwang/from_string branch from 20183eb to e9d3864 Compare June 24, 2025 19:15
@justinhwang justinhwang changed the title feat: change IndexFromString to return Cell feat: introduce CellFrom/ToString Jun 24, 2025
@justinhwang
Copy link
Collaborator Author

fwiw @jogly updated!

@justinhwang justinhwang merged commit e3ab92b into master Jun 25, 2025
14 checks passed
@justinhwang justinhwang deleted the justinhwang/from_string branch June 25, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogly jogly jogly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinhwang @coveralls @jogly
0