8000 Bump core library to 3.4.0, add getRes0Indexes by nrabinowitz · Pull Request #31 · uber/h3-js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump core library to 3.4.0, add getRes0Indexes #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 25, 2019
Merged

Bump core library to 3.4.0, add getRes0Indexes #31

merged 4 commits into from
Jan 25, 2019

Conversation

nrabinowitz
Copy link
Collaborator
  • Bumps core library to latest
  • Adds support for getRes0Indexes

nrabinowitz
nrabinowitz commented Jan 24, 2019
View reviewed changes
.npmignore
@@ -6,3 +6,5 @@ node_modules/
.*
build/
test/
*.sublime-project
*.sublime-workspace
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that these files were getting picked up in the package when I published from my local machine.

nrabinowitz
nrabinowitz commented Jan 24, 2019
View reviewed changes
.build-emscripten.sh
@@ -25,6 +25,9 @@ pushd h3c
git pull origin master --tags
git checkout "v$(cat ../H3_VERSION)"

# Run cmake - necessary for building h3api.h
cmake .
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a downstream effect of uber/h3#173 - may be relevant to other bindings as well.

@nrabinowitz nrabinowitz requested a review from jogly January 24, 2019 22:37
jogly
jogly approved these changes Jan 24, 2019
View reviewed changes
Copy link
@jogly jogly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@coveralls
Copy link
coveralls commented Jan 24, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 70

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 66: 0.0%
Covered Lines: 402
Relevant Lines: 402
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 71

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 66: 0.0%
Covered Lines: 402
Relevant Lines: 402
💛 - Coveralls

@nrabinowitz nrabinowitz merged commit 5b50f55 into uber:master Jan 25, 2019
@nrabinowitz nrabinowitz deleted the bump-3.4.0 branch January 25, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogly jogly jogly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nrabinowitz @coveralls @jogly
0