First part of unified h3 command
#497
Conversation
|
This looks great! One question though. Do we have a way to add tests for these commands? |
It would be integration testing (from the perspective of CMake) that we need to write. I have used shellspec to do this relatively cleanly in other projects. Do we want to potentially use that here but have it actively needed only if you run something like Thoughts @isaacbrodsky @ajfriend @nrabinowitz ? (In my own usage, I have the Makefile acquire the version of shellspec I want to use as a dependency for running the BDD tests so it could also be done without requiring changes to setup for github actions or in local development.) |
|
I don't have any concerns with using an additional tool for testing the CLI. Using shellspec seems reasonable. |
Only two functions implemented so far, but this demonstrates the potential pattern possible. This makes the sub-command names case-insensitive and forces sub-commands to be in explicit locations in the
argvlist. (Not just hardwired toargv[1]in case we ever need sub-commands of sub-commands).Work to tackle:
These can be in follow-up PRs, I hope?