10000 Add DuckDB, Sqlite3 bindings by isaacbrodsky · Pull Request #620 · uber/h3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add DuckDB, Sqlite3 bindings #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2022
Merged

Add DuckDB, Sqlite3 bindings #620

merged 1 commit into from
Jul 5, 2022

Conversation

isaacbrodsky
Copy link
Collaborator

No description provided.

@coveralls
Copy link
coveralls commented Jul 4, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 98.66% when pulling 9f6836c on isaacbrodsky-patch-1 into dbe1b7c on master.

@ajfriend
Copy link
Contributor
ajfriend commented Jul 5, 2022

Awesome! Super excited for the DuckDB bindings!

Also, it looks like you're having the same build issues as i was having in #617 . Something must have changed with the Windows containers?

@isaacbrodsky
Copy link
Collaborator Author

Awesome! Super excited for the DuckDB bindings!

Also, it looks like you're having the same build issues as i was having in #617 . Something must have changed with the Windows containers?

Yes, it appears the docs build has failed. #617 (comment) Perhaps some graphviz/dot/doxygen update happened or a component was removed. I think we can simply disable building docs in the Windows CI, or try something like https://github.com/marketplace/actions/install-graphviz

@isaacbrodsky isaacbrodsky mentioned this pull request Jul 5, 2022
Merged
nrabinowitz
nrabinowitz approved these changes Jul 5, 2022
View reviewed changes
Copy link
Collaborator
@nrabinowitz nrabinowitz left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!

@isaacbrodsky isaacbrodsky force-pushed the isaacbrodsky-patch-1 branch from 77bea1a to 9f6836c Compare July 5, 2022 17:15
dfellis
dfellis approved these changes Jul 5, 2022
View reviewed changes
Copy link
Collaborator
@dfellis dfellis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@isaacbrodsky isaacbrodsky merged commit 1e661dc into master Jul 5, 2022
@isaacbrodsky isaacbrodsky deleted the isaacbrodsky-patch-1 branch July 5, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrabinowitz nrabinowitz nrabinowitz approved these changes

@dfellis dfellis dfellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@isaacbrodsky @coveralls @ajfriend @nrabinowitz @dfellis
0