8000 Fix undefined behavior in areNeighborCells by isaacbrodsky · Pull Request #677 · uber/h3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix undefined behavior in areNeighborCells #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2022
Merged

Fix undefined behavior in areNeighborCells #677

merged 2 commits into from
Sep 8, 2022

Conversation

isaacbrodsky
Copy link
Collaborator

Expected to fix #676.

@coveralls
Copy link
coveralls commented Sep 6, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 99.034% when pulling 5e1bc06 on isaacbrodsky:directed-edge-undefined-areneighborcells into d8e8606 on uber:master.

nrabinowitz
nrabinowitz approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator
@nrabinowitz nrabinowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine - it would be simpler and potentially guarantee more coverage just to check both cells with isValidCell first, but that could have performance implications?

ajfriend
ajfriend approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor
@ajfriend ajfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but +1 to @nrabinowitz's suggestion to simplify code with a validity check on each cell. We could always revisit if speed becomes an issue.

@isaacbrodsky isaacbrodsky merged commit e5209fc into uber:master Sep 8, 2022
@isaacbrodsky isaacbrodsky deleted the directed-edge-undefined-areneighborcells branch September 8, 2022 02:07
@isaacbrodsky isaacbrodsky mentioned this pull request May 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrabinowitz nrabinowitz nrabinowitz approved these changes

@ajfriend ajfriend ajfriend approved these changes

@dfellis dfellis Awaiting requested review from dfellis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development
3FD6

Successfully merging this pull request may close these issues.

Stack buffer overflow in fuzzerDirectedEdge
4 participants
@isaacbrodsky @coveralls @nrabinowitz @ajfriend
0