Add the formula for number of indexes per resolution #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaachier
reviewed
Jun 4, 2018
| printf("};\n"); | ||
| } | ||
|
|
||
| int main(int argc, char* argv[]) { |
There was a problem hiding this comment.
Alternatively, you could change this to int main(void) and ignore the arguments entirely.
There was a problem hiding this comment.
If we make that change, I think it should be made to all the filters. edit: by which I mean all the apps its relevant for.
nrabinowitz
approved these changes
Jun 4, 2018
| printf("};\n"); | ||
| } | ||
|
|
||
| int main(int argc, char* argv[]) { |
mrdvt92
pushed a commit
to mrdvt92/h3
that referenced
this pull request
Jun 19, 2022
Add the formula for number of indexes per resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems a little inefficient to put into its own file, but I'll put it there for the moment and later refactor the generators. Especially so the generators do not depend on the files whose contents they are partly generating (perhaps have a generated tables file, and a base tables/constants file it's based off of.)