Fix a possible signed integer overflow in localIjToCell #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrabinowitz
approved these changes
Oct 6, 2022
| @@ -108,7 +108,7 @@ Direction _rotate60ccw(Direction digit); | |||
| Direction _rotate60cw(Direction digit); | |||
| int ijkDistance(const CoordIJK *a, const CoordIJK *b); | |||
| void ijkToIj(const CoordIJK *ijk, CoordIJ *ij); | |||
| void ijToIjk(const CoordIJ *ij, CoordIJK *ijk); | |||
| H3Error ijToIjk(const CoordIJ *ij, CoordIJK *ijk); | |||
There was a problem hiding this comment.
This makes me suspicious that we may need something similar for ijkToIj or the cube functions as well, might be worth adding tests.
There was a problem hiding this comment.
I am not sure if ijkToIj can be overflowed assuming that the input coordinates are all non-negative. We would need to be comfortable with that function only being called with IJK+ coordinates, of course.
|
I don't think my original test was correct (coverage decreased) and I updated. TBD if coverage is complete on the new test. |
dfellis
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This protects against a particular instance of signed integer overflow that would have occurred in
ijkNormalize.