8000 H3 CLI Region Subcommands by dfellis · Pull Request #923 · uber/h3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

H3 CLI Region Subcommands #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 14, 2024
Merged

H3 CLI Region Subcommands #923

merged 16 commits into from
Oct 14, 2024

Conversation

dfellis
Copy link
Collaborator
@dfellis dfellis commented Oct 7, 2024

Still as a draft because I've only hand tested some simple cases, and I know there's an issue with reading large polygon definitions from a file, but I wanted to get what I have up sooner rather than later so you can start taking a look at it.

@dfellis dfellis self-assigned this Oct 7, 2024
@coveralls
Copy link
coveralls commented Oct 7, 2024 •
edited
Loading

Coverage Status

coverage: 98.782%. remained the same
when pulling 03b8c97 on h3-cli-region-subcommands
into e8b1661 on master.

isaacbrodsky
isaacbrodsky reviewed Oct 7, 2024
View reviewed changes
@dfellis dfellis marked this pull request as ready for review October 8, 2024 03:34
isaacbrodsky
isaacbrodsky reviewed Oct 8, 2024
View reviewed changes
@dfellis
Copy link
Collaborator Author
dfellis commented Oct 8, 2024 •
edited
Loading

I just ran this failure locally (set up CMAKE with the same configuration) and I can't reproduce it. @isaacbrodsky any idea what's going on here?

EDIT: Resolved it myself by blowing away my cmake cache with git -ffdx. I didn't actually run the tests with the configuration in that CI run when I wasn't reproducing it.

isaacbrodsky
isaacbrodsky reviewed Oct 13, 2024
View reviewed changes
isaacbrodsky
isaacbrodsky reviewed Oct 13, 2024
View reviewed changes
@isaacbrodsky isaacbrodsky mentioned this pull request Oct 13, 2024
Merged
dfellis and others added 4 commits October 13, 2024 15:21
@dfellis @isaacbrodsky
Apply suggestions from code review
6d2fab5 
Co-authored-by: Isaac Brodsky <isaac@isaacbrodsky.com>
@dfellis
Fix formatting
ad7dddc
@dfellis
Abort polygon parsing early if we know the input is invalid
d3a5a77
@dfellis @isaacbrodsky
Apply suggestions from code review
bcaac46 
Co-authored-by: Isaac Brodsky <isaac@isaacbrodsky.com>
isaacbrodsky
isaacbrodsky reviewed Oct 14, 2024
View reviewed changes
@dfellis @isaacbrodsky
Update src/apps/filters/h3.c
8446f87 
Co-authored-by: Isaac Brodsky <isaac@isaacbrodsky.com>
nrabinowitz
nrabinowitz approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator
@nrabinowitz nrabinowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but overall this looks great!

@dfellis dfellis merged commit 33681ff into 6D40 master Oct 14, 2024
38 checks passed
@dfellis dfellis deleted the h3-cli-region-subcommands branch October 14, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrabinowitz nrabinowitz nrabinowitz approved these changes

@isaacbrodsky isaacbrodsky isaacbrodsky approved these changes

@ajfriend ajfriend Awaiting requested review from ajfriend

Assignees

@dfellis dfellis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dfellis @coveralls @nrabinowitz @isaacbrodsky
0