ci: include ubuntu arm test, clean up check names #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dfellis
approved these changes
Feb 25, 2025
ajfriend
approved these changes
Feb 25, 2025
How much longer does it take to run? Maybe try in a separate PR? We could also run it just for a subset of options on clang. We could also split these up to run a faster subset on draft PRs, like we do in h3-py. |
|
Also, I see a bunch of warnings in the Actions output. Maybe time to update the checkout (and other) actions, since that looks like where its coming from: |
ajfriend
pushed a commit
to ajfriend/h3
that referenced
this pull request
Mar 4, 2025
* ci: include ubuntu arm test, clean up check names * upgrade checkout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Linux arm64 test. I added it only for GCC to avoid exploding the test matrix (since clang has more options that are tested). It would be a valid configuration to also test, so open to suggestions. Maybe we throw it in?
Since the Github UI already shows which file the test comes from, including "Compile" or "Test" seem superfluous.