Fix a memory leak bug in function polygonStringToGeoPolygon
#976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pointer `verts` at line 14 is not freed before the function returns at line 34. Thus there is a memory leak bug.
`LatLng *verts = calloc(numVerts, sizeof(LatLng));`
```
if (curDepth > 4) {
// This is beyond the depth for a valid input, so we abort early
return E_FAILED;
}
```
|
|
dfellis
approved these changes
Feb 27, 2025
isaacbrodsky
approved these changes
Feb 27, 2025
ajfriend
pushed a commit
to ajfriend/h3
that referenced
this pull request
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pointer
vertsat line 14 of functionpolygonStringToGeoPolygonis not freed before the function returns at line 34. Thus there is a memory leak bug.LatLng *verts = calloc(numVerts, sizeof(LatLng));