8000 Add docs for h3Distance by isaacbrodsky · Pull Request #101 · uber/h3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add docs for h3Distance #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Conversation

isaacbrodsky
Copy link
Collaborator

Begins docs for #83, and adds h3Distance to the example.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f084ba1 on isaacbrodsky:distance-docs into e506b81 on uber:master.

Copy link
Collaborator
@nrabinowitz nrabinowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment


Returns the distance in grid cells between the two indexes.

Returns a negative number if finding the distance failed. Finding the distance can fail because the two
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth outlining the meaning of the different error codes here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h3Distance itself only returns -1 on any kind of error right now, it doesn't preserve the more specific error code from h3ToIjk

@nrabinowitz
Copy link
Collaborator

Out of curiousity, does our doc setup mean this will be published right away, before we actually cut a release with this functionality? Can we add something to the docs that indicates what version of the library they document?

@isaacbrodsky
Copy link
Collaborator Author

@nrabinowitz Our doc setup requires manually building the docs and pushing them to the gh-pages branch, so this will not be published until both merged and the docs are rebuilt.

It would be really nice to have a proper control on each of the docs page that says e.g. "Since: 3.1.0" or "Since: 3.0.0" or other annotations.

@isaacbrodsky isaacbrodsky merged commit 611f0e4 into uber:master Jul 30, 2018
@isaacbrodsky isaacbrodsky deleted the distance-docs branch July 30, 2018 18:29
mrdvt92 pushed a commit to mrdvt92/h3 that referenced this pull request Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0