gridRing in fuzzer #1012
gridRing in fuzzer #1012
Conversation
|
|
src/apps/applib/include/args.h
Outdated
| @@ -90,7 +90,7 @@ int _parseArgsList(int argc, char *argv[], int numArgs, Arg *args[], | |||
| // common arguments | |||
|
|
|||
| #define ARG_HELP \ | |||
| { .names = {"-h", "--help"}, .helpText = "Show this help message." } | |||
| {.names = {"-h", "--help"}, .helpText = "Show this help message."} | |||
There was a problem hiding this comment.
inadvertent formatting change?
src/apps/fuzzers/fuzzerGridDisk.c
Outdated
| if (results != NULL) { | ||
| H3_EXPORT(gridRing)(args->index, args->k, results); // Test the safe version | ||
| } | ||
| free(results); |
There was a problem hiding this comment.
| if (results != NULL) { | |
| H3_EXPORT(gridRing)(args->index, args->k, results); // Test the safe version | |
| } | |
| free(results); | |
| if (results != NULL) { | |
| H3_EXPORT(gridRing)(args->index, args->k, results); // Test the safe version | |
| } | |
| free(results); |
inadvertent formatting issue?
src/apps/fuzzers/fuzzerGridDisk.c
Outdated
| @@ -58,6 +58,11 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { | |||
| free(results); | |||
|
|
|||
| // TODO: use int64_t | |||
| results = calloc(sizeof(H3Index), sz); | |||
There was a problem hiding this comment.
the comment above belongs with the int *distances line below?
|
You may be using a different version of clang-format which is resulting in conflicting formatting and CI failing. You may want to reapply your commit with formatting disabled since it is just a few lines of code. |
|
Also, now that the other PR is merged, you can drop the incomplete commit and rebase on the latest commit in the repo. |
|
The rebase was giving me a lot of trouble with merging conflicts but I'm pretty sure they are all fixed and I opted for git add and used the ctang format file in the codebase to further correct format on top of my manual edits, I hope this has worked I will verify on my end for a bit, edit to comment** this is so odd my commit seemed to somehow add more format changes i thought I had formatting disabled let me resolve this |
|
Hi @shresss you need to |
This PR adds
gridRingtofuzzerGridDisk.cto improve test coverage, as requested in #1011.Related to @justinhwang's PR: #1011.