Update examples and docs for longitude range change (#93) #118
Conversation
CHANGELOG.md
Outdated
| @@ -6,6 +6,8 @@ The public API of this library consists of the functions declared in file | |||
| [h3api.h](./src/h3lib/include/h3api.h). | |||
|
|
|||
| ## [Unreleased] | |||
| ### Changed | |||
| - Longitude outputs are now ine range [-Pi, Pi]. (#93) | |||
There was a problem hiding this comment.
Typo: in range. I'd add guaranteed to be as well.
| // grid distance: 2340 | ||
| // distance in km: 2.256850km | ||
| // distance in km: 2.256853km |
There was a problem hiding this comment.
Curious why this changed - FPE? Why are all of the coords here so different in their fractional digits from the previous versions?
There was a problem hiding this comment.
The only difference I see here is 0.000003km difference on the distance. Not sure if that's important. The coords look like they are correctly updated to unconstrained_longitude - 360.
There was a problem hiding this comment.
...because apparently I can't do simple math, and wasn't expecting a different fraction with the sign change. 8000 Stet.
| // grid distance: 2340 | ||
| // distance in km: 2.256850km | ||
| // distance in km: 2.256853km |
There was a problem hiding this comment.
...because apparently I can't do simple math, and wasn't expecting a different fraction with the sign change. Stet.
Update examples and docs for longitude range change (uber#93)
No description provided.